1803959 - Enable pdf.js by default in GeckoView for nightly

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, task)

Comment 1

[Calixte Denizet (:calixte)]

Attachment: Bug 1803959 - Enable pdf.js by default in GeckoView for nightly r=#geckoview-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d031b559f26
Enable pdf.js by default in GeckoView for nightly r=geckoview-reviewers,m_kato

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing pdf content failures.

• backout: https://hg.mozilla.org/integration/autoland/rev/dec0c0888e95cb8db893a910083cedba54b1dad5
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=fNiTnkZlRhuBCTRakwcSow.0&revision=4d031b559f2609b88e2644d5dce28ef2dacd9efc
• failure log: https://treeherder.mozilla.org/logviewer?job_id=398882579&repo=autoland&lineNumber=2898

[task 2022-12-07T11:24:26.005Z] 11:24:26     INFO - TEST-PASS | /loading/early-hints/iframe-coep-disallow.h2.html | Early hints for an iframe that violates Cross-Origin-Embedder-Policy should be ignored. 
[task 2022-12-07T11:24:26.005Z] 11:24:26     INFO - TEST-UNEXPECTED-FAIL | /loading/early-hints/iframe-pdf.h2.window.html | Early hints for an iframe of which content is pdf should be ignored. - promise_test: Unhandled rejection with value: object "SecurityError: Permission denied to access property "performance" on cross-origin object"
[task 2022-12-07T11:24:26.076Z] 11:24:26     INFO - TEST-OK | /loading/early-hints/iframe-pdf.h2.window.html | took 2157ms

Comment 4

[Natalia Csoregi [:nataliaCs]]

Another failure:

• TEST-UNEXPECTED-PASS | /html/browsers/browsing-the-web/navigating-across-documents/plugin-document.historical.html | Same-origin PDFs must not create accessible Document objects - expected FAIL
• TEST-UNEXPECTED-FAIL | /html/semantics/embedded-content/the-iframe-element/sandbox_004.htm | Fallback content is always displayed for sandboxed PDFs - assert_less_than: expected a number less than 300 but got 600

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:calixte, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 6

[Makoto Kato [:m_kato]]

Both failure tests are should set if os == "android": [PASS, FAIL] in meta files because nightly has PDF.js, but beta/release doesn't have it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97a7ac381051
Enable pdf.js by default in GeckoView for nightly r=geckoview-reviewers,m_kato

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/97a7ac381051