Open Bug 1803966 Opened 1 year ago Updated 1 year ago

Consider to not trigger the paint of the initial about:blank so eagerly when doing a process switch

Categories

(Core :: DOM: Content Processes, enhancement, P3)

enhancement

Tracking

()

REOPENED

People

(Reporter: smaug, Assigned: smaug)

References

Details

(Keywords: perf)

Attachments

(1 file)

right now the extra paint tends to show up in the profiles rather often

This is a micro-optimization to process switching. Often the paint delayes child process to send back information that it is ready to receive data from the parent process.
There are be other tiny issues like this too.

Severity: -- → S3
Type: defect → enhancement
Priority: -- → P3
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b9e2c9256f8
Consider to not trigger the paint of the initial about:blank so eagerly when doing a process switch, r=emilio
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
Regressions: 1786514

This caused regressions and a spike in failure rate for Bug 1786514, Bug 1792516 and Bug 1789145.

Backout link: https://hg.mozilla.org/integration/autoland/rev/07a25d3cdd49528091cdeaf3b958a6ce88c3af3a

Retriggers Bug 1786514 here.

Retriggers Bug 1792516 here.

Retriggers Bug 1789145 here.

Status: RESOLVED → REOPENED
Flags: needinfo?(smaug)
Resolution: FIXED → ---
Target Milestone: 109 Branch → ---
No longer regressions: 1786514

(In reply to Cosmin Sabou [:CosminS] from comment #4)

This caused regressions and a spike in failure rate for Bug 1786514, Bug 1792516 and Bug 1789145.

Backout link: https://hg.mozilla.org/integration/autoland/rev/07a25d3cdd49

== Change summary for alert #36413 (as of Mon, 12 Dec 2022 07:06:51 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
46% fandom FirstVisualChange (geomean) linux1804-64-shippable-qr fission warm webrender 72.18 -> 105.19
40% fandom FirstVisualChange (mean) linux1804-64-shippable-qr fission warm webrender 76.08 -> 106.63
40% fandom ContentfulSpeedIndex (geomean) linux1804-64-shippable-qr fission warm webrender 78.04 -> 109.28
36% fandom ContentfulSpeedIndex (mean) linux1804-64-shippable-qr fission warm webrender 81.06 -> 110.49
35% fandom ContentfulSpeedIndex linux1804-64-shippable-qr fission warm webrender 83.88 -> 113.33
7% fandom PerceptualSpeedIndex linux1804-64-shippable-qr fission warm webrender 214.08 -> 229.77

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
45% outlook FirstVisualChange macosx1015-64-shippable-qr fission warm webrender 200.00 -> 110.00
41% twitter FirstVisualChange macosx1015-64-shippable-qr bytecode-cached fission warm webrender 390.00 -> 230.00
39% twitter FirstVisualChange (geomean) macosx1015-64-shippable-qr fission warm webrender 393.96 -> 241.83
38% twitter FirstVisualChange macosx1015-64-shippable-qr fission warm webrender 390.00 -> 243.33
34% twitter FirstVisualChange (mean) macosx1015-64-shippable-qr fission warm webrender 398.85 -> 262.53
... ... ... ... ...
10% twitter PerceptualSpeedIndex macosx1015-64-shippable-qr fission warm webrender 591.80 -> 531.50

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36413

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:smaug, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(smaug)
Flags: needinfo?(emilio)
Flags: needinfo?(smaug)
Flags: needinfo?(emilio)
No longer blocks: 1739417
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: