1804017 - Crash in [@ mozilla::Maybe<T>::emplace | nsPrintJob::ReflowPrintObject]

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/b871f846-bdb3-42be-a0b8-14c340221204

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(!isSome())

Top 10 frames of crashing thread:

0  xul.dll  mozilla::Maybe<bool>::emplace  mfbt/Maybe.h:844
0  xul.dll  nsPrintJob::ReflowPrintObject  layout/printing/nsPrintJob.cpp:1315
1  xul.dll  nsPrintJob::ReflowDocList  layout/printing/nsPrintJob.cpp:957
2  xul.dll  nsPrintJob::ReflowDocList  layout/printing/nsPrintJob.cpp:960
3  xul.dll  nsPrintJob::InitPrintDocConstruction  layout/printing/nsPrintJob.cpp:996
4  xul.dll  nsPrintJob::DoCommonPrint  layout/printing/nsPrintJob.cpp:445
5  xul.dll  nsPrintJob::CommonPrint  layout/printing/nsPrintJob.cpp:334
6  xul.dll  nsPrintJob::PrintPreview  layout/printing/nsPrintJob.cpp:466
7  xul.dll  nsDocumentViewer::PrintPreview  layout/base/nsDocumentViewer.cpp:2966
8  xul.dll  nsGlobalWindowOuter::Print  dom/base/nsGlobalWindowOuter.cpp:5281

Given the time-frame this is most likely a regression from bug 1800546, Emily can you have a look please?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1800546

Comment 2

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1804017 - Fix asserts when ReflowPrintObject is called multiple times on the same print job

Comment 3

[Emily McDonough [:alaskanemily]]

Yes, this is definitely caused by bug 1800546, it should be quite simple to fix.

Comment 4

[Gabriele Svelto [:gsvelto]]

Thanks for the quick fix!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e42cc6df64cc
Fix asserts when ReflowPrintObject is called multiple times on the same print job r=emilio

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e42cc6df64cc