1804078 - Create non-generated module for shared UniFFI JS code

Status: RESOLVED FIXED

(Toolkit :: UniFFI Bindings, enhancement)

Description

[Ben Dean-Kawamura [:bdk]]

We should create a JS module for shared UniFFI code. This module should just be static code rather than generated. This provides a few benefits:

• Reduces runtime size since each generated component can import from it.
• Makes the code easier to understand since it's regular JS, not JS mixed with template code.
• We can run the code through a JS linter.

Some things to include in this module:

• Most/all of the code in Helpers.js including:
  • The FfiConverter base class
  • ArrayBufferDataStream
  • handleRustResult
  • UniFFIError and UniFFIInternalError
• Some commonly used FfiConverters, especially FfiConverterString
• UniFFICallbackHandler and UniFFICallbackMethodHandler

Comment 1

[Ben Dean-Kawamura [:bdk]]

This is something I'd love to do for all the UniFFI bindings languages, maybe trying it out on JS could be a first step.

Comment 2

[Ben Dean-Kawamura [:bdk]]

Attachment: Bug 1804078 - Shared UniFFI module, r=bgruber

Running ./mach lint revealed a bug: we needed parentheses in the
!(instanceof Uint8Array) check.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e9d717fa8206
https://hg.mozilla.org/integration/autoland/rev/acc2fca04c3e
Shared UniFFI module, r=bgruber

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/acc2fca04c3e