1804086 - Make sure the content we passed to the Javascript parser in the Utility Process are utf-8 encoded for ORB

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Sean Feng [:sefeng211]]

For ORB, we need to ensure the content that we are passing to the JS parser are utf-8 encoded.

Comment 1

[Henri Sivonen (:hsivonen)]

It probably makes sense to start with a manually-monomorphized copypaste of what ScriptLoader::ConvertToUTF8 expands to. Perhaps the ORB and ScriptLoader code paths can be refactored back together later. The strangest bit there is the case where aDocument is null. I don't recall when that occurs, but it falls back to windows-1252.

Comment 2

[Andreas Farre [:farre]]

I wonder if Document::GetDocumentCharacterSet() is something we should expose on WindowContext.

Comment 3

[Sean Feng [:sefeng211]]

Attachment: Bug 1804086 - Allow classic script hint to be passed from content to parent r=farre,smaug

This is needed for doing content decoding for ORB.

Comment 4

[Sean Feng [:sefeng211]]

Attachment: Bug 1804086 - Allow document charset to be passed from content to parent r=farre,smaug

This is needed for doing content decoding for ORB.

Depends on D172490

Comment 5

[Sean Feng [:sefeng211]]

Attachment: Bug 1804086 - Make JSValidatorChild decoding the data from other encoding into UTF8 if needed r=farre,smaug

Depends on D172491

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00feb14e7824
Allow classic script hint to be passed from content to parent r=smaug,necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/1bea9ea5e20d
Allow document charset to be passed from content to parent r=smaug,necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/12a40a80a975
Make JSValidatorChild decoding the data from other encoding into UTF8 if needed r=smaug

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39129 for changes under testing/web-platform/tests

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1804086) for causing failures in JSValidatorChild.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=ZJ_3efQhQGSF2RfMt_rVeg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=12a40a80a9757d658928c97c0c3af6c15302fca2

Log: https://treeherder.mozilla.org/logviewer?job_id=409729901&repo=autoland&lineNumber=4938

Backout: https://hg.mozilla.org/integration/autoland/rev/91cb2bd51f4d5189faf4b113c83dece997a576ef

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b86f3d846ada
Allow classic script hint to be passed from content to parent r=smaug,necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/d5948770d0a1
Allow document charset to be passed from content to parent r=smaug,necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/0b351d3ec6c6
Make JSValidatorChild decoding the data from other encoding into UTF8 if needed r=smaug

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b86f3d846ada
https://hg.mozilla.org/mozilla-central/rev/d5948770d0a1
https://hg.mozilla.org/mozilla-central/rev/0b351d3ec6c6

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot