[wpt-sync] Sync PR 37336 - Fix DCHECK with Text*coderStream
Categories
(Core :: Internationalization, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox110 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 37336 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/37336
Details from upstream follow.
Adam Rice <ricea@chromium.org> wrote:
Fix DCHECK with Text*coderStream
When write() or close() was called on a TextEncoderStream or
TextDecoderStream in a detached realm it would cause a DCHECK failure
due to the context being invalid. Check for an invalid context and throw
an exception proactively.BUG=1395588
Change-Id: Iafab2d90a2a35da01dfd811e4d0501a2971a5db5
Reviewed-on: https://chromium-review.googlesource.com/4080291
WPT-Export-Revision: 37a56fe45cdc6b381c26d195757085695dc7f06f
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
CI Results
Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 4 subtests
Status Summary
Firefox
TIMEOUT
: 2
NOTRUN
: 3
Chrome
OK
: 1
PASS
: 4
Safari
OK
: 1
PASS
: 4
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
- /encoding/streams/invalid-realm.window.html [wpt.fyi]:
TIMEOUT
- TextDecoderStream: write in detached realm should succeed:
TIMEOUT
- TextEncoderStream: write in detached realm should succeed:
NOTRUN
- TextEncoderStream: close in detached realm should succeed:
NOTRUN
- TextDecoderStream: close in detached realm should succeed:
NOTRUN
- TextDecoderStream: write in detached realm should succeed:
New Tests That Don't Pass
- /encoding/streams/invalid-realm.window.html [wpt.fyi]:
TIMEOUT
(Chrome:OK
, Safari:OK
)- TextDecoderStream: write in detached realm should succeed:
TIMEOUT
(Chrome:PASS
, Safari:PASS
) - TextEncoderStream: write in detached realm should succeed:
NOTRUN
(Chrome:PASS
, Safari:PASS
) - TextEncoderStream: close in detached realm should succeed:
NOTRUN
(Chrome:PASS
, Safari:PASS
) - TextDecoderStream: close in detached realm should succeed:
NOTRUN
(Chrome:PASS
, Safari:PASS
)
- TextDecoderStream: write in detached realm should succeed:
Comment 4•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/902afdb8862d
https://hg.mozilla.org/mozilla-central/rev/a8434ec74e11
Description
•