Closed Bug 1804192 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 37336 - Fix DCHECK with Text*coderStream

Categories

(Core :: Internationalization, task, P4)

task

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37336 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37336
Details from upstream follow.

Adam Rice <ricea@chromium.org> wrote:

Fix DCHECK with Text*coderStream

When write() or close() was called on a TextEncoderStream or
TextDecoderStream in a detached realm it would cause a DCHECK failure
due to the context being invalid. Check for an invalid context and throw
an exception proactively.

BUG=1395588

Change-Id: Iafab2d90a2a35da01dfd811e4d0501a2971a5db5
Reviewed-on: https://chromium-review.googlesource.com/4080291
WPT-Export-Revision: 37a56fe45cdc6b381c26d195757085695dc7f06f

Component: web-platform-tests → Internationalization
Product: Testing → Core

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

TIMEOUT: 2
NOTRUN : 3

Chrome

OK : 1
PASS : 4

Safari

OK : 1
PASS : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /encoding/streams/invalid-realm.window.html [wpt.fyi]: TIMEOUT
    • TextDecoderStream: write in detached realm should succeed: TIMEOUT
    • TextEncoderStream: write in detached realm should succeed: NOTRUN
    • TextEncoderStream: close in detached realm should succeed: NOTRUN
    • TextDecoderStream: close in detached realm should succeed: NOTRUN

New Tests That Don't Pass

  • /encoding/streams/invalid-realm.window.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: OK)
    • TextDecoderStream: write in detached realm should succeed: TIMEOUT (Chrome: PASS, Safari: PASS)
    • TextEncoderStream: write in detached realm should succeed: NOTRUN (Chrome: PASS, Safari: PASS)
    • TextEncoderStream: close in detached realm should succeed: NOTRUN (Chrome: PASS, Safari: PASS)
    • TextDecoderStream: close in detached realm should succeed: NOTRUN (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/902afdb8862d [wpt PR 37336] - Fix DCHECK with Text*coderStream, a=testonly https://hg.mozilla.org/integration/autoland/rev/a8434ec74e11 [wpt PR 37336] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.