1804255 - [wpt-sync] Sync PR 37349 - [scroll-animations] Tree-scoped timeline lookups

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 37349 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37349
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[scroll-animations] Tree-scoped timeline lookups

This CL implements tree-scoped lookups for animation-timeline.

Previously, we could search for a timeline match on a given element
with a normal lookup in a hash table. This is unfortunately not enough
anymore, since tree-scoped lookups don't require exact matches, but
instead match any name in the target tree-scope or higher.
Therefore the lookup process now linearly iterates through the items
of the hash table. (We still store the timelines in a hash table
despite this linear traversal, because we use exact-match hash
lookups during CSSAnimations::CalculateTimelineUpdate).

Fixed: 1382876
Change-Id: I4aa5ef03a663e201e97810b1f668036b90958316
Reviewed-on: https://chromium-review.googlesource.com/4079252
WPT-Export-Revision: b6ae8cbe7e4dc7423ae7b0ae7f38c669e0f4d37e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=70dfa5c450fb409cd11c41b59f0ad79d4f9d50c3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

OK : 2
FAIL : 6
ERROR: 2

Chrome

OK : 2
FAIL : 6

Safari

OK : 2
FAIL : 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /scroll-animations/css/scroll-timeline-name-tree-scoped.html [wpt.fyi]: ERROR [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], OK [GitHub] (Chrome: OK, Safari: OK)
  • Outer animation can not see scroll timeline defined by :host: FAIL (Chrome: FAIL, Safari: FAIL)
  • Outer animation can not see scroll timeline defined by ::slotted: FAIL (Chrome: FAIL, Safari: FAIL)
  • Inner animation can see scroll timeline defined by ::part: FAIL (Chrome: FAIL, Safari: FAIL)
• /scroll-animations/css/view-timeline-name-tree-scoped.html [wpt.fyi]: ERROR [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], OK [GitHub] (Chrome: OK, Safari: OK)
  • Outer animation can not see view timeline defined by :host: FAIL (Chrome: FAIL, Safari: FAIL)
  • Outer animation can not see view timeline defined by ::slotted: FAIL (Chrome: FAIL, Safari: FAIL)
  • Inner animation can see view timeline defined by ::part: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af564d7ce43f
[wpt PR 37349] - [scroll-animations] Tree-scoped timeline lookups, a=testonly
https://hg.mozilla.org/integration/autoland/rev/6ced7a88531c
[wpt PR 37349] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/af564d7ce43f
https://hg.mozilla.org/mozilla-central/rev/6ced7a88531c