Closed Bug 1804348 Opened 3 years ago Closed 3 years ago

`moz-phab submit` displays escape codes instead of colors on the Windows/MSYS console

Categories

(Conduit :: moz-phab, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mpohle, Assigned: mpohle)

Details

Attachments

(1 file, 1 obsolete file)

When called from a Windows console I get to see escape codes instead of colors. It is possible to set ui.no_ansi in the ~/.moz-phab-config to work around this by disabling colors, but I attached a patch with a possible fix. It adds a dependency to colorama, which is included in the mozilla build environment by default: https://searchfox.org/mozilla-central/source/tools/moztreedocs/requirements.txt#53

Assignee: nobody → mpohle
Status: NEW → ASSIGNED
Attachment #9306964 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: