1804394 - Use SharedShape and DictionaryShape more

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Jan de Mooij [:jandem]]

As a first step for bug 1804253, we can move more methods from Shape into the SharedShape and DictionaryShape subclasses.

This will also start using SharedShape more in the engine, which is nice because it makes it clearer that these shapes are never dictionary shapes.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 1 - Call SharedShape constructor instead of Shape constructor. r?jonco!

This fixes a small regression from the cx->newCell refactoring.

Also change the return types for the new_ methods to be more precise.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 2 - Start using SharedShape in more places. r?jonco!

Change some return types and hash tables to use SharedShape* instead of Shape*.

Depends on D164051

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 3 - Move some methods from Shape to DictionaryShape. r?jonco!

Depends on D164052

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 4 - Move lastPropertyMatchesForAdd from Shape to SharedShape. r?jonco!

Depends on D164053

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 5 - Move slotspan methods from Shape to SharedShape. r?jonco!

This introduces some asShared() calls that will be changed in later patches
by passing SharedShape around more.

Depends on D164054

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 6 - Use SharedShape more for array shapes. r?jonco!

Depends on D164055

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 7 - Use SharedShape more for function shapes. r?jonco!

Depends on D164056

Comment 8

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 8 - Use SharedShape more for plain object shapes. r?jonco!

Depends on D164057

Comment 9

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 9 - Use SharedShape for setShapeAndAdd* methods. r?jonco!

Depends on D164058

Comment 10

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 10 - Use SharedShape for object creation code. r?jonco!

Depends on D164059

Comment 11

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 11 - Change calculateDynamicSlots argument from Shape to SharedShape. r?jonco!

Depends on D164060

Comment 12

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 12 - Move propMap accessors to SharedShape and DictionaryShape. r?jonco!

Depends on D164061

Comment 13

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 13 - Use getLastProperty instead of ShapePropertyIter in a few places. r?jonco!

Depends on D164062

Comment 14

[Jan de Mooij [:jandem]]

Attachment: Bug 1804394 part 14 - Add and use SharedShapePropertyIter. r?jonco!

This is just a specialization of ShapePropertyIter that can be optimized better
by the compiler because we don't need to check for dictionary holes in the property
map.

Depends on D164063

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bfed98940bc
part 1 - Call SharedShape constructor instead of Shape constructor. r=jonco
https://hg.mozilla.org/integration/autoland/rev/bf3139410812
part 2 - Start using SharedShape in more places. r=jonco
https://hg.mozilla.org/integration/autoland/rev/0b5b1b9b7347
part 3 - Move some methods from Shape to DictionaryShape. r=jonco
https://hg.mozilla.org/integration/autoland/rev/1c62fa16c3c5
part 4 - Move lastPropertyMatchesForAdd from Shape to SharedShape. r=jonco
https://hg.mozilla.org/integration/autoland/rev/4d7e164ace7c
part 5 - Move slotspan methods from Shape to SharedShape. r=jonco
https://hg.mozilla.org/integration/autoland/rev/fc73e81a1500
part 6 - Use SharedShape more for array shapes. r=jonco
https://hg.mozilla.org/integration/autoland/rev/b06f1ad1dab5
part 7 - Use SharedShape more for function shapes. r=jonco
https://hg.mozilla.org/integration/autoland/rev/427fc6ae28a3
part 8 - Use SharedShape more for plain object shapes. r=jonco
https://hg.mozilla.org/integration/autoland/rev/0677d828899c
part 9 - Use SharedShape for setShapeAndAdd* methods. r=jonco
https://hg.mozilla.org/integration/autoland/rev/9f6bb6be2624
part 10 - Use SharedShape for object creation code. r=jonco
https://hg.mozilla.org/integration/autoland/rev/2fc531eaa0f6
part 11 - Change calculateDynamicSlots argument from Shape to SharedShape. r=jonco
https://hg.mozilla.org/integration/autoland/rev/aaac22184f87
part 12 - Move propMap accessors to SharedShape and DictionaryShape. r=jonco
https://hg.mozilla.org/integration/autoland/rev/fffb9b66b015
part 13 - Use getLastProperty instead of ShapePropertyIter in a few places. r=jonco
https://hg.mozilla.org/integration/autoland/rev/07b8e2565736
part 14 - Add and use SharedShapePropertyIter. r=jonco

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1bfed98940bc
https://hg.mozilla.org/mozilla-central/rev/bf3139410812
https://hg.mozilla.org/mozilla-central/rev/0b5b1b9b7347
https://hg.mozilla.org/mozilla-central/rev/1c62fa16c3c5
https://hg.mozilla.org/mozilla-central/rev/4d7e164ace7c
https://hg.mozilla.org/mozilla-central/rev/fc73e81a1500
https://hg.mozilla.org/mozilla-central/rev/b06f1ad1dab5
https://hg.mozilla.org/mozilla-central/rev/427fc6ae28a3
https://hg.mozilla.org/mozilla-central/rev/0677d828899c
https://hg.mozilla.org/mozilla-central/rev/9f6bb6be2624
https://hg.mozilla.org/mozilla-central/rev/2fc531eaa0f6
https://hg.mozilla.org/mozilla-central/rev/aaac22184f87
https://hg.mozilla.org/mozilla-central/rev/fffb9b66b015
https://hg.mozilla.org/mozilla-central/rev/07b8e2565736