Closed Bug 1804461 Opened 1 year ago Closed 1 year ago

Remove `SingleByteRegs` from non x86 architectures.

Categories

(Core :: JavaScript Engine: JIT, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: nbp, Assigned: mdh, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

x86 has al, ah, bl, bh, cl, ch, dl, dh single byte registers. This set is used to encode whether among all x64/x86 extended register we properly allocated one which has the ability of being used as a byte-size register.

Most likely for copy and paste reasons, other architectures inherited this trait, which is simply meaning less on other architectures which do not have the same legacy as i386 assembly.

See https://searchfox.org/mozilla-central/search?q=SingleByteReg&path=&case=false&regexp=false

Hi, I'd like to pick this up as a first SpiderMonkey task.

Remove SingleByteRegs constants from non-x86 architectures for which they
don't make sense.

Assignee: nobody → mdh
Status: NEW → ASSIGNED

Thanks for contributing! The patch sounds good.
The repository is under soft-code-freeze, I will merge it next Tuesday.

Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49c9f7b06869
Remove `SingleByteRegs` from non x86 architectures r=nbp
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.