1804466 - Navigating through Datepicker using keyboard after a date has already been selected will loose keyboard focus when reaching a different month

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: 2022-12-07_14h39_38.mp4

Found in

• 109.0a1 (2022-12-07)

Affected versions

• Firefox Nightly 109.0a1 (2022-12-07)

Affected platforms

• Ubuntu, Mac, Windows

Steps to reproduce

1. Reach url: data:text/html, <input type='date'>
2. Use keyboard navigation in order to open the Datepicker.
3. Use the Arrow keys to navigate between days from previous or next month.
4. Select any Date and reopen the calendar.
5. Use the arrow keys until you reach a different month.

Expected result

• The Calendar should show the Keyboard navigation focus after switching between months using the arrow keys.

Actual result

• After hitting the UP/Down arrow until the month is changed the Keyboard focus resets outside of the calendar and the user has to reach the Days again using the Tab key.

Please note that the first time when we navigate through the days from previous or next months, before any date has been selected, this issue does not occur.

Regression range
This issue is not a regression.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, [access-s2].
:dao, could you consider increasing the severity?

For more information, please visit auto_nag documentation.

Comment 2

[Anna Yeddi [:ayeddi]]

After the focus management code refactoring bug 1803608 was landed, it appears that the issue reported in the current bug was fixed. I will submit a patch anyways to add automatic tests to cover both the case when the date was selected (in STR) and when month-year button was used to change the month too (in the video).

:Rares, would your team be able to verify the fix manually? It is live in current Nightly 111 and the fix is also approved to be uplifted for 110 beta 5.

Comment 3

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1804466 - Add tests to ensure the focus is not lost after a datepicker reopens. r=kcochrane

Ensure navigating through Datepicker using keyboard after a date has already been selected will loose keyboard focus when reaching a different month. The new tests cover both cases reported:

1. When selection is done on the calendar grid
2. When selection is done on the month-year panel

Comment 4

[Rares Doghi, Desktop QA]

Hi @Anna, This issue is Verified as fixed in our latest Nightly Build 111.0a1 (2023-01-24).

Comment 5

[Anna Yeddi [:ayeddi]]

(In reply to Rares Doghi from comment #4)

Hi @Anna, This issue is Verified as fixed in our latest Nightly Build 111.0a1 (2023-01-24).

Thank you for verifying it, Rares!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d29394cee316
Add tests to ensure the focus is not lost after a datepicker reopens. r=kcochrane

Comment 7

[Anna Yeddi [:ayeddi]]

setting up the status-firefox110 flag to fix-optional because it is technically fixed in 110 Beta 5, but the tests are riding the 111 train

Comment 8

[Cristian Tuns]

Backed out for causing bc failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_datetime_datepicker_keynav.js | Test timed out -

Comment 9

[Anna Yeddi [:ayeddi]]

(In reply to Cristian Tuns from comment #8)

• Failure line: TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_datetime_datepicker_keynav.js | Test timed out -

This should be resolved by the bug 1802621 - patch is in progress

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10995d003439
Add tests to ensure the focus is not lost after a datepicker reopens. r=kcochrane

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/10995d003439

Comment 12

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 111.0a1 (2023-01-30).