Closed Bug 1804472 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 37375 - [webrtc-stats] Only expose hardware capabilities when capturing media

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
110 Branch
Tracking Flags:
Tracking Status
firefox110 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37375 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37375
Details from upstream follow.

Evan Shrubsole <eshr@google.com> wrote:

[webrtc-stats] Only expose hardware capabilities when capturing media

With a recent change to the webrtc-stats spec, user agents with a
fullscreen element will no longer have access to stats which expose
hardware capabilities.

The WPT tests for hardware capability stats has been updated to reflect
the fact that having a fullscreen element is not sufficient anymore,
rather than just removing these tests. This helps catch user agents that
have not updated to reflect this change to the spec.

Bug: 1398362
Change-Id: I221be5bfb900952c29459ce38b1fa1460205a1e3

Reviewed-on: https://chromium-review.googlesource.com/4084785
WPT-Export-Revision: 2909b05f38e1e3986f2cfb63882d01b810cacc14

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 12 subtests

Status Summary

Firefox

OK : 1
FAIL : 12
TIMEOUT: 1

Chrome

OK : 1
PASS : 8
FAIL : 4

Safari

OK : 1
PASS : 4
FAIL : 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /webrtc-stats/hardware-capability-stats.https.html [wpt.fyi]
    • powerEfficientEncoder not exposed when not capturing.: FAIL
    • encoderImplementation not exposed when not capturing.: FAIL
    • powerEfficientDecoder not exposed when not capturing.: FAIL
    • decoderImplementation not exposed when not capturing.: FAIL

New Tests That Don't Pass

  • /webrtc-stats/hardware-capability-stats.https.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome: OK, Safari: OK)
    • powerEfficientEncoder not exposed when not capturing.: FAIL (Chrome: PASS, Safari: PASS)
    • powerEfficientEncoder not exposed when fullscreen and not capturing.: FAIL (Chrome: FAIL, Safari: FAIL)
    • powerEfficientEncoder exposed when capturing.: FAIL (Chrome: PASS, Safari: FAIL)
    • encoderImplementation not exposed when not capturing.: FAIL (Chrome: PASS, Safari: PASS)
    • encoderImplementation not exposed when fullscreen and not capturing.: FAIL (Chrome: FAIL, Safari: FAIL)
    • encoderImplementation exposed when capturing.: FAIL (Chrome: PASS, Safari: FAIL)
    • powerEfficientDecoder not exposed when not capturing.: FAIL (Chrome: PASS, Safari: PASS)
    • powerEfficientDecoder not exposed when fullscreen and not capturing.: FAIL (Chrome: FAIL, Safari: FAIL)
    • powerEfficientDecoder exposed when capturing.: FAIL (Chrome: PASS, Safari: FAIL)
    • decoderImplementation not exposed when not capturing.: FAIL (Chrome: PASS, Safari: PASS)
    • decoderImplementation not exposed when fullscreen and not capturing.: FAIL (Chrome: FAIL, Safari: FAIL)
    • decoderImplementation exposed when capturing.: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e8db3e2db13e [wpt PR 37375] - [webrtc-stats] Only expose hardware capabilities when capturing media, a=testonly https://hg.mozilla.org/integration/autoland/rev/9d39d1dbf747 [wpt PR 37375] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e8db3e2db13e
https://hg.mozilla.org/mozilla-central/rev/9d39d1dbf747

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox110: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.