Closed Bug 1804669 Opened 1 year ago Closed 1 year ago

Users can delete the Calendar button with Backspace

Categories

(Core :: Layout: Form Controls, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
110 Branch
Tracking Status
firefox-esr102 --- disabled
firefox107 --- disabled
firefox108 --- disabled
firefox109 --- wontfix
firefox110 --- verified

People

(Reporter: rdoghi, Assigned: ayeddi)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Attached video 2022-12-08_14h28_05.mp4

Found in

  • 109.0a1 (2022-12-08)

Affected versions

  • Firefox Nightly 109.0a1 (2022-12-08)

Affected platforms

  • Ubuntu, Mac, Windows

Steps to reproduce

  1. Reach url: data:text/html,<input type='datetime-local'>
  2. Reach the Calendar button using keyboard navigation.
  3. Hit the Backspace button while focused on the Calendar button.

Expected result

  • The selected date should be deleted.
    The Calendar button should not disappear from the Datepicker.

Actual result

  • Hitting the Backspace button while on the Calendar button will cause it to disappear.

Regression range
This issue is not a regression.

Blocks: 1806587

The user should not be able to remove the Calendar button with Backspace, I'll send a patch for that.

The first part of the expected behavior - The selected date should be deleted. - is to be decided by the Layout team, if this functionality is expected for Backspace while on Calendar button or not under a separate bug, if that's okay.

Prevent removing a Calendar button when a Backspace is pressed while it's focused for <input type=date> and <input type=datetime-local>.

This patch does not add cleaning the entire field as this is to be decided under a separate enhancement bug 1806587

Assignee: nobody → ayeddi
Status: NEW → ASSIGNED
Pushed by ayeddi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1de20be14b0d
Do not remove a Calendar button from date input on Backspace. r=mconley
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch

This issue is Verified as fixed in our latest build 110.0a1 (2022-12-21).

The patch landed in nightly and beta is affected.
:ayeddi, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(ayeddi)
Flags: needinfo?(ayeddi)

Updating the Main Status Flag.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: