1804678 - Implement RTCMediaSourceStats

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement)

Description

[Andreas Pehrson [:pehrsons]]

RTCMediaSourceStats with its trackIdentifier entry is handy for correlating outbound-rtp stats to a track, when using RTCPeerConnection.getStats.

This would include RTCOutboundRtpStreamStats.mediaSourceId.

It is also on the mandatory to implement list.

Comment 1

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=481c735a1442a94394c8dcfae2d2dcfda397cee1
https://treeherder.mozilla.org/jobs?repo=try&revision=e591440fcbf52a83ce5a59051cca1e16316631c1

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1804678: Test cases for bug. r?ng

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1804678: Implement MediaSourceStats. r?ng

Depends on D169125

Comment 4

[Byron Campen [:bwc]]

Try looks fine so far, still waiting on macos tests...

Comment 5

[Byron Campen [:bwc]]

Macos looks good too.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62130501686f
Test cases for bug. r=ng
https://hg.mozilla.org/integration/autoland/rev/ed64251d7fc6
Implement MediaSourceStats. r=ng,webidl,saschanaz

Comment 7

[Cristian Tuns]

Backed out for causing build bustages on PeerConnectionImpl.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp:2024:38: error: unused variable 'id' [-Werror=unused-variable]

mochitest log: https://treeherder.mozilla.org/logviewer?job_id=405685822&repo=autoland

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bde3813fbfc4
Test cases for bug. r=ng
https://hg.mozilla.org/integration/autoland/rev/0859596a5ec3
Implement MediaSourceStats. r=ng,webidl,saschanaz

Comment 9

[Sandor Molnar]

Backed out for causing wpt failures in

Backout link: https://hg.mozilla.org/integration/autoland/rev/19e0bc283894a3bf801c7edb6c73879c3aeec836

Push with failures

Failure log #1 | TEST-UNEXPECTED-TIMEOUT | /webrtc/RTCPeerConnection-remote-track-mute.https.html | pc.close() on one side causes mute events on the other - Test timed out

Failure log #2 | TEST-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() audio and video validate all mandatory stats - assert_equals: Expect dictionary.transportId to be string expected "string" but got "undefined"

Failure log #3 | TEST-UNEXPECTED-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() on track associated with RTCRtpReceiver should return stats report containing inbound-rtp stats - assert_unreached: required stats <...>

Comment 10

[Byron Campen [:bwc]]

Looks like fixing the timeout in this test...

https://searchfox.org/mozilla-central/rev/84fb1c4511312a0b9187f647d90059e3a6dd27f8/testing/web-platform/meta/webrtc/RTCPeerConnection-getStats.https.html.ini#12-14

...allowed these (broken) tests to start running, which would have intermittently failed if they had ever been run...

https://searchfox.org/mozilla-central/rev/84fb1c4511312a0b9187f647d90059e3a6dd27f8/testing/web-platform/meta/webrtc/RTCPeerConnection-getStats.https.html.ini#28-30,36-38

I'll file bugs and disable these.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:bwc, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e642639befc5
Test cases for bug. r=ng
https://hg.mozilla.org/integration/autoland/rev/b7750fa69be6
Implement MediaSourceStats. r=ng,webidl,saschanaz

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e642639befc5
https://hg.mozilla.org/mozilla-central/rev/b7750fa69be6