1804698 - Space bar scrolls down when used in the month/year spin selection buttons

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Ina Popescu, Desktop QA]

Found in

• Firefox Nightly 109.0a1

Affected versions

• Firefox Nightly 109.0a1

Tested platforms

• Affected platforms: Windows 10, Ubuntu 18, macOS 11
• Unaffected platforms: none

Preconditions

• Firefox Nightly installed

Steps to reproduce

1. Open the datepicker
2. Click on month/year button
3. Focus by hitting TAB the month or year spin toggle button
4. Hit Space bar

Expected result

• Space bar should have identical behavior as the Enter key it should close the month-year selection panel, returning the focus to the month-year toggle button. Closing the entire panel would also suffice, because technically the panel with spinners replaces the calendar panel.

Actual result

• Space bar scrolls down when used in the month/year spin selection buttons

Regression range

• Not a regression because these improvements were recently implemented through Bug 1676068.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:epopescu, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1804698 - Handle Space and Enter keys on month-year spinners of the datepicker. r=Jamie,mconley,kcochrane

Space bar should have identical behavior as the Enter key it should close the month-year selection panel, returning the focus to the month-year toggle button. Closing the entire panel would also suffice, because technically the panel with spinners replaces the calendar panel.

Comment 3

[Ina Popescu, Desktop QA]

Attachment: Month-Year selection using Enter key.gif

Comment 4

[Ina Popescu, Desktop QA]

Following the STR from Comment 0, but using Enter key instead of Space doesn't have the expected behavior: "Enter/Space selects the current value of the spinbutton (value that is centered)".
Currently Space/Enter keys close the Month/Year selection panel when the Month/Year toggle button is focused( screen recording attached), but the value from Month/Year selection Spinbuttons can not be selected by simply hitting Space/Enter keys.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c46102ada4e
Handle Space and Enter keys on month-year spinners of the datepicker. r=Jamie,mconley,kcochrane

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8c46102ada4e

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ayeddi, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Ina Popescu, Desktop QA]

Verified as fixed on Nightly 110.0a1 (2022-12-20) on Windows 10, maOS 11 and Ubuntu 22.04.
Enter/Space keys select the current value of the spinbuttons (value that is centered) and close the Month/Year selection panel.
If the input field is empty, the 1st of the month is focused in the calendar.