Closed Bug 1804771 Opened 6 months ago Closed 6 months ago

Change moz-toggle implementation to use a button with `role="switch`

Categories

(Toolkit :: XUL Widgets, enhancement)

Product:
Toolkit
Component:
XUL Widgets
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
110 Branch
Tracking Flags:
Tracking Status
firefox110 --- fixed

People

(Reporter: hjones, Assigned: hjones)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-reusable-components-ms1])

Attachments

(1 file)

Bug 1804771 - change toggle to use a button r=mstriemer,tgiles
48 bytes, text/x-phabricator-request
Details | Review

Our initial toggle implementation was based on using a checkbox input, but since we've started trying to use it in a few places in the Firefox codebase it has become clear that what we're trying to implement is more of a toggle button. We do not support the use case of having an indeterminate or mixed state, and we always expect actions to occur immediately when the toggle is clicked, rather than waiting on a form submit. To express this more clearly, we will switch the toggle to be a button with role="switch" and with an aria-pressed attribute.

Attachment #9307831 - Attachment description: WIP: Bug 1804771 - changing toggle implementation → Bug 1804771 - change toggle to use a button r=mstriemer,tgiles
Pushed by hjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c79103fc182f
change toggle to use a button r=mstriemer

https://hg.mozilla.org/mozilla-central/rev/c79103fc182f

Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox110: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.