Closed
Bug 1804842
Opened 2 years ago
Closed 2 years ago
Refactor GetDecimal not to directly depend on JSContext
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
110 Branch
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
TokenStream uses GetDecimal and related functions, and they require JSContext parameter just to allocate Vector<char, 32> chars(cx) with TempAllocPolicy.
those functions needs to be refactored not to use JSContext, but allocator + error reporter separately (or just FrontendContext), so that they can be used from frontend (TokenStream) without JSContext
|
Assignee | |
Comment 1•2 years ago
|
||
Depends on D164333
|
||
Comment 2•2 years ago
|
||
What if we remove the context parameter completely and let the caller report OOM?
|
|
Assignee | |
Comment 3•2 years ago
|
||
That sounds simpler.
I'll modify the patch.
|
||
Updated•2 years ago
|
Attachment #9307552 -
Attachment description: WIP: Bug 1804842 - Use FrontendContext in GetDecimal. r?bthrall! → Bug 1804842 - Remove JSContext from GetDecimal. r?bthrall!
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/2606db55b8e5
Remove JSContext from GetDecimal. r=bthrall
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox110:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•