1804921 - Remove the extensions.manifestV3.enabled pref

Status: RESOLVED FIXED

(WebExtensions :: General, task, P3)

Description

[Rob Wu [:robwu]]

With extensions.manifestV3.enabled having been enabled by default in bug 1801291, we should eventually remove this pref.

In unit tests, this was used to enable MV3 extensions when it was previously off by default. There is only one test that sets the pref to false: https://searchfox.org/mozilla-central/rev/196b6aa0427f38058fd43ac90ee94fcf2f436fb6/toolkit/mozapps/extensions/test/browser/browser_html_detail_permissions.js#394,505-507

In various places, e.g. on AMO, we make the assumption that MV3 is supported since 109, so we should ideally remove the ability to turn off MV3.

Side note: regardless of this pref, MV2 continues to be supported. The pref was only used to control Firefox's ability to load extensions with "manifest_version": 3 in its manifest.json file.

Comment 1

[Rachel Rusiecki]

I’m a new contributor, and I’ll be submitting a patch for this bug soon.

Comment 2

[Rachel Rusiecki]

Attachment: Bug 1804921 - Remove the extensions.manifestV3.enabled pref. r=robwu,toolkit-telemetry-reviewers

Comment 3

[Rachel Rusiecki]

I removed the pref from all files, including test files. The test referenced above where the pref is set to false, I just deleted. I figured that since it was on by default, the test was no longer necessary, but let me know if I am mistaken or if there is anything else I need to do.

Comment 4

[Rob Wu [:robwu]]

The patch is in WIP state. Could you drop the WIP state? I think that the moz-phab tool automatically sets the WIP state when the patch has no reviewers. Although you added [:robwu] to the commit message, it did not automatically set the reviewer because the format should have been with r=, e.g. r=robwu instead.

moz-phab submits each commit as a separate patch. To make sure that you update the patch instead of adding another patch, edit the commit instead of creating a new commit, with git commit --am .

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dfc58e117f8a
https://hg.mozilla.org/integration/autoland/rev/a2b362479c8d
Remove the extensions.manifestV3.enabled pref. r=robwu,toolkit-telemetry-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cd3a65e94808
https://hg.mozilla.org/integration/autoland/rev/72209b96cca6
Revert "Bug 1804921 - Remove the extensions.manifestV3.enabled pref. r=robwu,toolkit-telemetry-reviewers" for causing xpcshell failures on test_Chrome_extensions.

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for causing xpcshell failures on test_Chrome_extensions.

Push with failures

Failure log

Backout link

Comment 8

[Rob Wu [:robwu]]

The test failure is caused by a test-only issue that would resolve on its own within a day or two, explained at bug 1769184, specially https://bugzilla.mozilla.org/show_bug.cgi?id=1769184#c3

The test has test tag "condprof" due to https://searchfox.org/firefox-main/rev/54da8f6bfead7871ca89f2cb18323af5f00d9620/browser/components/migration/tests/unit/xpcshell.toml#6,49

To avoid the test failure, we should temporarily skip the test, and re-enable the test after 2 days. Skipping can be done with a one-line change, e.g. as seen at https://phabricator.services.mozilla.com/D211342

Comment 9

[Rachel Rusiecki]

Attachment: Bug 1804921 - Remove skip-if condprof from test_Chrome_extensions.js r=robwu

Comment 10

[Rachel Rusiecki]

Okay, I think I understand. I submitted a new WIP for this bug. Is the file the same as the example (xpcshell.toml) that needs the skip line?

Comment 11

[Rob Wu [:robwu]]

(In reply to Rachel Rusiecki from comment #10)

Okay, I think I understand. I submitted a new WIP for this bug. Is the file the same as the example (xpcshell.toml) that needs the skip line?

No, the change needs to be made in the toml file I linked from my comment, after the line with "test_Chrome_extensions.js". Please include that change in your original patch.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6d1fbb323935
https://hg.mozilla.org/integration/autoland/rev/cc1d741bc684
Remove the extensions.manifestV3.enabled pref. r=robwu,toolkit-telemetry-reviewers

Comment 13

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/cc1d741bc684

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/628102e30e49
https://hg.mozilla.org/integration/autoland/rev/0b11248202d8
Remove skip-if condprof from test_Chrome_extensions.js r=robwu,migration-reviewers,Gijs

Comment 15

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/0b11248202d8