1804924 - Allow willReadFrequently to control whether DrawTargetWebgl is created

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, enhancement)

Description

[Lee Salzman [:lsalzman]]

In previous discussion on Matrix with Kelsey and pdf.js team, we had determined it might be useful to have an option to disable attempts to accelerate Canvas2D. There is in fact already willReadFrequently both in the spec (https://github.com/fserb/canvas2D/blob/master/spec/will-read-frequently.md) and our internal documentation (https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/getContext) and our IDL (https://searchfox.org/mozilla-central/source/dom/webidl/CanvasRenderingContext2D.webidl#19).

So all that remains is to actually use this attribute to control whether we use DrawTargetWebgl or not...

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1804924 - Don't use DrawTargetWebgl when willReadFrequently is set. r?jgilbert,jrmuizel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d43ff0044fe
Don't use DrawTargetWebgl when willReadFrequently is set. r=jrmuizel

Comment 3

[Cristian Tuns]

Backed out for causing build bustages

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/gfx/layers/PersistentBufferProvider.cpp(663,38): error: no member named 'front' in 'mozilla::Vector<RefPtr<mozilla::layers::TextureClient>, 7>'

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/169fe70ad296
Don't use DrawTargetWebgl when willReadFrequently is set. r=jgilbert,jrmuizel

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/169fe70ad296