More preparation patches for flexbox fragmentation
Categories
(Core :: Layout: Flexbox, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(4 files)
These patches has been developed while working on bug 1743890. I'd love to have them reviewed sooner to reduce the size of my patch stacks.
|
Assignee | |
Comment 1•2 years ago
|
||
- Remove the return value since it is never used.
- Store the newly create flex item in a reference since EmplaceBack() returns
NonNull<FlexItem*>.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
This is a follow-up of Bug 1622935 Part 1
https://hg.mozilla.org/mozilla-central/rev/78d4dfbda06a
The variable storing the return value of ReflowChildren should be renamed, too.
Depends on D164396
|
|
Assignee | |
Comment 3•2 years ago
|
||
When I first implemented flexbox fragmentation, all the children in flex
container's next-in-flows are all put in one FlexLine, because we assume the
position of flex items won't shift in fragmentation. However, when we implement
more granular control of flexbox fragmentation such as pushing a tall flex item
to next page/column, we'll need the information of flex lines.
This patch doesn't change behavior.
Depends on D164397
|
|
Assignee | |
Comment 4•2 years ago
|
||
ReflowChildren() needs more bookkeeping data to correctly place tall flex items
being pushed from prev-in-flows during fragmentation. This is a preparation for
bug 1743890 that is going to add more fields to the struct.
This patch doesn't change behavior.
Depends on D164398
|
|
||
Updated•2 years ago
|
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/839db4e824d3 Part 1 - Simplify GenerateFlexItemForChild(). r=dholbert https://hg.mozilla.org/integration/autoland/rev/d64666546386 Part 2 - Rename areChildrenComplete to anyChildIncomplete. r=dholbert https://hg.mozilla.org/integration/autoland/rev/03648e81a801 Part 3 - When building a flex container's next-in-flows, carry forward its items' groupings into distinct FlexLines. r=dholbert https://hg.mozilla.org/integration/autoland/rev/0404d371c42f Part 4 - Move SumOfChildrenBlockSizeProperty into a struct. r=dholbert
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/839db4e824d3
https://hg.mozilla.org/mozilla-central/rev/d64666546386
https://hg.mozilla.org/mozilla-central/rev/03648e81a801
https://hg.mozilla.org/mozilla-central/rev/0404d371c42f
Description
•