Closed Bug 1805059 Opened 2 years ago Closed 2 years ago

Use Assert.ok()/Assert.equal() instead of ok()/is() in Password Manager browser and unit tests

Categories

(Toolkit :: Password Manager, task, P1)

task

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: serg, Assigned: serg)

References

(Regressed 2 open bugs)

Details

Attachments

(1 file)

I believe we're (slowly) trying to veer away from using is, ok, etc in our mochitest-browser tests - in favour of using Assert.ok, Assert.equal instead. Can we use Assert.equal here, and Assert.ok elsewhere?

Per :mconley comment here https://phabricator.services.mozilla.com/D158155#inline-901663

Severity: -- → N/A
Priority: -- → P1
Summary: Use Assert.ok()/Assert.equal() instead of ok()/is() in Password Manager tests → Use Assert.ok()/Assert.equal() instead of ok()/is() in Password Manager browser and unit tests
Assignee: nobody → sgalich
Status: NEW → ASSIGNED
Depends on: 1805060
No longer depends on: 1805060
No longer depends on: 1805054
Pushed by sgalich@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a30893385a4b Using Assert.ok()/Assert.equal() instead of ok()/is() in password manager browser and unit tests r=mconley,dimi
Regressions: 1805339
Regressions: 1805340
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: