1805154 - focus outline changes and tooltip disappears when pressing enter on any PIP controls button

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Janvi Bajoria [:janvi01]]

Attachment: Screenshot 2022-12-09 at 5.50.02 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36

Steps to reproduce:

1. Open PiP
2. Press the tab key so that controls have a keyboard focus
3. Press Enter

Actual results:

focus outline changes and the tooltip disappears

Expected results:

The tooltip should remain and the outline should be the same

Comment 1

[Janvi Bajoria [:janvi01]]

Attachment: Screenshot 2022-12-09 at 5.50.14 PM.png

Comment 2

[kpatenio]

I can reproduce this issue on MacOS 12.5.1 following the STR provided by Janvi. Thanks!

Comment 3

[Janvi Bajoria [:janvi01]]

Attachment: Bug 1805154 - fix pip controls focus outline and tooltip after pressing enter r=kpatenio,niklas

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03b41e417755
fix pip controls focus outline and tooltip after pressing enter r=kpatenio

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/03b41e417755

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2022-12-12 Nightly build on macOS 12.
Verified as fixed on Firefox 110.0b3(build ID: 20230119185824) and Nightly 111.0a1(build ID: 20230119163652) on macOS 12, Ubuntu 22, Windows 10.