1805330 - Fix Gecko handling of alpha channel in BMP images on clipboard

Status: NEW

(Core :: Widget: Win32, defect, P2)

Description

[Ashley Hale [:ahale]]

This bug tracks part of the work on Bug 460969 - fixing the clipboard bitmap and BMP file handling of alpha channel.

Comment 1

[Ashley Hale [:ahale]]

Attachment: Bug 1805330 - Fix clipboard handling of transparent BMP images

Comment 2

[Gian-Carlo Pascutto [:gcp]]

What's the status of this bug? It's marked as S2 but seems to have stalled?

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Edgar, do you know the status for this?

Comment 4

[Timothy Nikkel (:tnikkel)]

I think the status is "waiting for updates based on review comments".

Comment 5

[Ashley Hale [:ahale]]

I got stuck on how to implement reftests for this - we have no test functionality that I am aware of for inter-app compatibility of clipboard copy/paste, so it's kind of a heavy lift to figure out how to add that functionality as I'm not familiar with the Gecko code in general (my focus is on WebRender - fixing this bug is more of a pet-peeve thing I did to learn my way around the code).

So I am not really sure how to proceed on this other than pushing it to Nightly and seeing if anyone complains, which isn't a great position to be in, but we really don't have any test infra I am aware of for this.

Comment 6

[Jim Mathies [:jimm]]

(In reply to Ashley Hale [:ahale] from comment #5)

So I am not really sure how to proceed on this other than pushing it to Nightly and seeing if anyone complains, which isn't a great position to be in, but we really don't have any test infra I am aware of for this.

That's a pretty typical approach to os integration bugs in Widget. We'll get bug reports if something major breaks, especially on Windows.

Comment 7

[Timothy Nikkel (:tnikkel)]

I posted a comment to the phab review for suggestions for how to get his unstuck.

(In reply to Ashley Hale [:ahale] from comment #5)

I got stuck on how to implement reftests for this - we have no test functionality that I am aware of for inter-app compatibility of clipboard copy/paste, so it's kind of a heavy lift to figure out how to add that functionality as I'm not familiar with the Gecko code in general (my focus is on WebRender - fixing this bug is more of a pet-peeve thing I did to learn my way around the code).

The request for testing in the review was not for testing of the clipboard code, but of the bmp encoder changes. We already have good testing infrastructure for testing image encoders in the file https://searchfox.org/mozilla-central/source/image/test/reftest/encoders-lossless/reftest.list and adding a testcase to cover this case should be straight forward.

Comment 8

[Edgar Chen [:edgar]]

(There is some update from :tnikkel and :ahale already)

Comment 9

[Ray Kraesig [:rkraesig]]

(If either this or bug 1940790 is addressed, the other bug, as well as the meta bug 460969, can be reduced to S3.)

Comment 10

[Greg Stoll :gstoll]

:handyman: Since bug 1940790 has been fixed, per comment 9 do we want to reduce this and bug 460969 to S2?

Comment 11

[David Parks [:handyman]]

sgtm