1805372 - Pass effectiveTRRMode to nsHttpChannel from socketTransport.

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

The patch in bug 1596845 only works when network.dns.disablePrefetch = false.
If DNS prefetch is disabled, the channel doesn't get OnLookupComplete so we have to take the effectiveTRRMode from the transaction/socketTransport.

This might be tricky, as we don't always deliver OnTransportStatus notification when the resolution fails.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1805372 - Pass effectiveTRRMode to nsHttpChannel from socketTransport/DnsAndConnectSocket r=#necko

Depends on D164347

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Networking: DNS' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: WIP: Bug 1805372 - unit_ipc//test_trr_noPrefetch_wrap.js r=#necko

Depends on D164539

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/521c9e019678
Pass effectiveTRRMode to nsHttpChannel from socketTransport/DnsAndConnectSocket r=necko-reviewers,kershaw

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out 1 changesets (Bug 1805372) for causing wpt failures in nsHttpTransaction.h

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=N_yglX77Souno2kaVwsCJQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=521c9e019678f584590f63473416d40e03f33342&searchStr=%2Clinux%2C18.04%2Cx64%2Cwebrender%2Ctsan%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-linux1804-64-tsan-qr%2Fopt-web-platform-tests%2Cwpt22

Log: https://treeherder.mozilla.org/logviewer?job_id=408880218&repo=autoland&lineNumber=8443

Backout: https://hg.mozilla.org/integration/autoland/rev/324dd82a3d3f78b60fcef1c35edb8772498cb752

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e7c97a37073
Pass effectiveTRRMode to nsHttpChannel from socketTransport/DnsAndConnectSocket r=necko-reviewers,kershaw

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8e7c97a37073