1805378 - Simplify devtools workers

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

This is mostly to followup on these two comments:
https://phabricator.services.mozilla.com/D162964#5386807
Where the console spawn a duplicate instance of parser worker, and the parser worker should be using task instead of invoke function.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1805378 - [devtools] Use WorkerDispatcher.task in Parser worker.

This prevents recreating a complex method each time we call WorkerDispatcher.invoke.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1805378 - [devtools] Remove unused getNextStep method from the parser worker.

As well as its leftover dependencies.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1805378 - [devtools] Reuse toolbox parser worker from the webconsole.

Note that we still have to instantiate a Webconsole dedicated one in case of Browser Console,
which won't have any toolbox offhand.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1805378 - [devtools] Convert WorkerDispatcher to ES Class.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1805378 - [devtools] Automatically start the worker on first WorkerDispatcher invoke/task call.

Because of this, we have to now pass the worker URL via WorkerDispatcher constructor.
Doing this should help then extend WorkerDispatcher instead of manually instantiating it.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1805378 - [devtools] Make all debugger worker use the same pattern an inherit from WorkerDispatcher.

Also align the one worker in netmonitor.

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1805378 - [devtools] Make the SourceMapLoader be instantiated per toolbox.

This complexify the existing tests a bit, but will make the management from the Toolbox more obvious.

(Also I forgot to remove the source-map-loader from the list of browser loader module...)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/926ce2f2d51f
[devtools] Use WorkerDispatcher.task in Parser worker. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/9a1e0541748a
[devtools] Remove unused getNextStep method from the parser worker. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/975bd01106d7
[devtools] Reuse toolbox parser worker from the webconsole. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/1bd4fec4b964
[devtools] Convert WorkerDispatcher to ES Class. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/bd89280bde1a
[devtools] Automatically start the worker on first WorkerDispatcher invoke/task call. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/5479ff3a475f
[devtools] Make all debugger worker use the same pattern an inherit from WorkerDispatcher. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/4dd1ad435728
[devtools] Make the SourceMapLoader be instantiated per toolbox. r=bomsy

Comment 9

[Serban Stanca [:SerbanS]]

Backed out for causing failures in source-map-loader.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | damp | source-map/source-map-loader.js: TypeError: sourceMap.startSourceMapWorker is not a function

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/689046028162
[devtools] Use WorkerDispatcher.task in Parser worker. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/784c086d0975
[devtools] Remove unused getNextStep method from the parser worker. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/1fb0d941f15b
[devtools] Reuse toolbox parser worker from the webconsole. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/af8bee46fcd6
[devtools] Convert WorkerDispatcher to ES Class. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/2a0d24f91df3
[devtools] Automatically start the worker on first WorkerDispatcher invoke/task call. r=bomsy,perftest-reviewers,kshampur
https://hg.mozilla.org/integration/autoland/rev/f7b7152487d0
[devtools] Make all debugger worker use the same pattern an inherit from WorkerDispatcher. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/9272c5d75533
[devtools] Make the SourceMapLoader be instantiated per toolbox. r=bomsy,perftest-reviewers,kshampur

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/689046028162
https://hg.mozilla.org/mozilla-central/rev/784c086d0975
https://hg.mozilla.org/mozilla-central/rev/1fb0d941f15b
https://hg.mozilla.org/mozilla-central/rev/af8bee46fcd6
https://hg.mozilla.org/mozilla-central/rev/2a0d24f91df3
https://hg.mozilla.org/mozilla-central/rev/f7b7152487d0
https://hg.mozilla.org/mozilla-central/rev/9272c5d75533