1805387 - On Firefox locales with long strings the title of the PDF callout message overlaps with the "X" button

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: ss of the issue.png

[Affected versions]:

• Firefox Beta 109.0b1 - Build ID: 20221212143511

[Affected Platforms]:

• Windows 10 x64
• macOS 12.6
• ubuntu 20.04 x64

[Prerequisites]:

• Have a Firefox Beta 109 "fr" locale installed.
• Have a new Firefox profile with the "nimbus.debug" pref set to "true" in the "about:config" page.

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Navigate to about:studies?optin_slug=pdfjs-feature-callout&optin_branch=treatment-b&optin_collection=nimbus-preview.
3. Navigate to an URL ending in ".pdf" (e.g. https://www.africau.edu/images/default/sample.pdf).
4. Observe the PDF callout message.

[Expected result]:

• All the elements from the PDF callout message are visible.

[Actual result]:

• The callout title overlaps with the "X" button.

[Additional Notes]:

• This issue is also reproducible on Firefox "de" locale.
• Attached a screenshot of the issue.

Comment 1

[Meg Viar [:mviar]]

Confirmed this misalignment can occur in translated and untranslated text for Feature Callout messages without images. It cuts off at most one letter.

We could reduce the margins around the dismiss button, or increase the margin on the end of the title element.

@vtay do you consider this a blocker for the experiment and therefore a candidate for uplift? I'd imagine this may also affect some translations in the second step of the Firefox View feature tour.

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1805387 - On Firefox locales with long strings the title of the PDF callout message overlaps with the X button

Comment 3

[Vtay]

As discussed, this is a candidate for uplift. We have discussed a fix for this which should be low risk/low engineering effort.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2530f7588e10
On Firefox locales with long strings the title of the PDF callout message overlaps with the X button r=jprickett

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2530f7588e10

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mviar, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Meg Viar [:mviar]]

Comment on attachment 9308128 [details]
Bug 1805387 - On Firefox locales with long strings the title of the PDF callout message overlaps with the X button

Beta/Release Uplift Approval Request

• User impact if declined: The title string of some Feature Callout messages (such as those in Firefox View and an upcoming PDF.js experiment) will be truncated for users in some locales.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

[Prerequisites]:
- Firefox with "fr" locale installed.
- Have a new Firefox profile with the "nimbus.debug" pref set to "true" in the "about:config" page.

[ Steps ]:
- Open the browser with the profile from the prerequisites.
- Navigate to about:studies?optin_slug=pdfjs-feature-callout&optin_branch=treatment-b&optin_collection=nimbus-preview.
- Navigate to an URL ending in ".pdf" (e.g. https://www.africau.edu/images/default/sample.pdf).
- Observe the PDF callout message.

[Expected result]:
All the elements from the PDF callout message are visible and the title text is not truncated.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small CSS change that is scoped to this specific messaging surface. The change has been approved by representatives from design and UX.
• String changes made/needed: n/a
• Is Android affected?: No

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9308128 [details]
Bug 1805387 - On Firefox locales with long strings the title of the PDF callout message overlaps with the X button

Approved for 109.0b3.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b2cb7e78cdad

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Nightly FR locale (110.0a1 Build ID - 20221215092759) installed on Windows 10 x64, macOS 12.6.1, and Ubuntu 22.04 x64. I can confirm that all the elements from the PDF callout message are visible and the title text is not truncated.

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Beta DE locale (109.0b3 Build ID - 20221215185833) installed on Windows 10 x64, macOS 12.6.1, and Ubuntu 22.04 x64. I can confirm that all the elements from the PDF callout message are visible and the title text is not truncated.