1805401 - Disable MOZ_NEW_XULSTORE in nightly

Status: RESOLVED FIXED

(Core :: XUL, task)

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1805401: Disable MOZ_NEW_XULSTORE in nightly. r=NeilDeakin!

Just disable in the build config for now. It is unlikely that any issues will
come up since this is disabled in release but just in case this will allow us
to re-enable it quickly.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bfb5438d2ae
Disable MOZ_NEW_XULSTORE in nightly. r=NeilDeakin

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing python failures on lint.py

Backout link

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f66b140c4c37
Disable MOZ_NEW_XULSTORE in nightly. r=NeilDeakin

Comment 5

[Atila Butkovits]

Backed out for causing build bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/825cf21d8ec944c44e78b67ab185be0b09d81820

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f66b140c4c374da2fa090187a3663c09f27f45ac&selectedTaskRun=Cf4mL8bkSGmx3VF_n5j-0g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=399888984&repo=autoland&lineNumber=694

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b21074f1b52
Disable MOZ_NEW_XULSTORE in nightly. r=NeilDeakin

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing bustages on XULPersist.h and failures in nsCOMPtr.h.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/xul/XULPersist.h:42:3: error: no template named 'nsCOMPtr'

And also:

• Push with failures
• Failure Log
• Failure line: SUMMARY: ThreadSanitizer: data race /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h:373:13 in assign_assuming_AddRef

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mossop, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 9

[Dave Townsend [:mossop]]

Back from sickness/vacation. Still working on this.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62f1d80cf044
Disable MOZ_NEW_XULSTORE in nightly. r=NeilDeakin

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/62f1d80cf044