1805430 - Minor improvements for dictionary shapes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Jan de Mooij [:jandem]]

Some minor follow-up (perf) improvements for allocating dictionary shapes after bug 1804253.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1805430 part 1 - Handle dictionary shapes in Shape::replaceShape too. r?jonco!

This makes the code for dictionary shapes more similar to the other shapes and
simplifies the callers.

It's also more efficient because instead of cloning the shape and then mutating it,
the new shape now has the right contents from the start.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1805430 part 2 - Optimize generateNewDictionaryShape a bit. r?jonco!

Adds a constructor that takes the object for which we want to create a new shape,
so that we can get rid of some roots.

Depends on D164571

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1805430 part 3 - Use replaceShape also for dictionary shapes in changeProperty. r?jonco!

Now that replaceShape also works for dictionary shapes, we don't need the isShared check anymore.

Depends on D164572

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6116446bee0d
part 1 - Handle dictionary shapes in Shape::replaceShape too. r=jonco
https://hg.mozilla.org/integration/autoland/rev/84cd838aa64c
part 2 - Optimize generateNewDictionaryShape a bit. r=jonco
https://hg.mozilla.org/integration/autoland/rev/5f0c1d530596
part 3 - Use replaceShape also for dictionary shapes in changeProperty. r=jonco

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6116446bee0d
https://hg.mozilla.org/mozilla-central/rev/84cd838aa64c
https://hg.mozilla.org/mozilla-central/rev/5f0c1d530596