Open Bug 1805474 Opened 3 years ago

Rollback should remove RTCRtpSender/RTCRtpReceiver.transport if the offer being rolled back is what set it

Categories

(Core :: WebRTC: Signaling, defect, P3)

Product:
Core
Component:
WebRTC: Signaling
Type:
defect

Tracking

()

People

(Reporter: bwc, Unassigned)

Details

This is causing failures in RTCPeerConnection-setRemoteDescription-rollback.html. Chrome, Edge, and Safari do not have this bug, but it is pretty minor I think. The problem seems to be here:

https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp#2476-2479

We should be comparing against |newSignalingState|, not |mSignalingState|, since we have not updated mSignalingState yet. We should also double-check for similar errors here.

You need to log in before you can comment on or make changes to this bug.