1805603 - Confused li marker position with text-align

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, defect)

Description

[Woody Li]

Firefox for Android

Steps to reproduce:

Default li element style list-style-position is outside.
So what's the marker position with text-align:center|right?
<ul>
<li style="text-align:right">test content</li>
<ul>

Actual results:

The marker is placed at near the text on right.

Expected results:

The marker is placed at the block inline-start.
Both Chrome, Edge and Safari displays as this result.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Block and Inline' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Daniel Holbert [:dholbert]]

I can reproduce, though oddly it seems to fix itself if I add any text-align:left li elements [EDIT: This was wrong, it's actually the presence of a direction:rtl element somewhere that seems to fix things for me. See upcoming reference case.]

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: reference case 1: just added a `direction:rtl` element, which somehow fixes the issue

Comment 5

[Daniel Holbert [:dholbert]]

dshin or tlouw might be interested to take a look, if they have cycles & are interested to pick up a (hopefully) small correctness bug.

Comment 6

[David Shin[:dshin]]

Code of interest is around where we align inline frames. Looks like we should not be shifting marker frames.
Having RTL present in the document activates unicode-bidi, which happens to do reordering and take markers into account instead of shifting all frames.

Comment 7

[David Shin[:dshin]]

Attachment: Bug 1805603: When aligning inline frames for `text-align`, ignore marker frames. r=#layout-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8628fe4290e
When aligning inline frames for `text-align`, ignore marker frames. r=emilio

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37741 for changes under testing/web-platform/tests

Comment 10

[Noemi Erli[:noemi_erli]]

Backed out changeset a8628fe4290e (Bug 1805603) for causing failures in marker-text-align-002.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a8628fe4290ee86b5dc916f640d0cb765cabe24a&selectedTaskRun=TWACexeCSoKUczJ7yjJ0ng.0

Log: https://treeherder.mozilla.org/logviewer?job_id=401233421&repo=autoland&lineNumber=3025
https://treeherder.mozilla.org/logviewer?job_id=401230665&repo=autoland&lineNumber=19029

Backout: https://hg.mozilla.org/integration/autoland/rev/3982de53eb6f0168a9b5c882c9748ddbd9900631

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/616a6f1689dc
When aligning inline frames for `text-align`, ignore marker frames. r=emilio

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/616a6f1689dc

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot