1805682 - OnDiskMessageMetadataStorage does not delete data or protect against IOExceptions

Status: NEW

(Firefox for Android :: Experimentation and Telemetry, defect, P3)

Description

[Jonathan Almeida [:jonalmeida]]

In our OnDiskMessageMetadataStorage, we have an incomplete CRUD storage layer - where do we delete the metadata? It looks like we're always appending metadata and not considering user storage.

For comparsion with tab state, that is a core part of the browser, so we should avoid losing tab state data where we can (even then, we delete tab data when the tab is removed). With messaging metadata, the remote server can keep sending our users data and we have no way to control this if the core browser is not able to function properly.

In Sentry/Socorro, we can see that our users are frequented with low disk space already (through other means if not by us), and this situation will lead us to keep filing up the device as we use more messaging over time.

See also: https://github.com/mozilla-mobile/fenix/pull/24473#pullrequestreview-1217622887

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Joe M [:jmahon]]

Marking this as an S4 because it's technically not currently a problem for users, but could be in the event of a backend bug (as Jonathan points out in the linked PR). We should fix it at some point to be safe.