1805836 - The "Shortcut will open with Enhanced Tacking Protection disabled" text is displayed when ETP is enabled

Status: VERIFIED FIXED

(Focus :: General, defect)

Description

[miralobontiu]

Attachment: add to homescreen.png

Steps to reproduce

1. Install the latest Focus Beta 109.0b1 on your device.
2. Open a page, like wikipedia.org.
3. From the three-dot menu, select the "Add to Home screen" option.
4. Observe the text under the "Cancel" / "Add" options from the prompt.

Expected behavior

There is no text under the "Cancel"/"Add" options, because the ETP is not disabled.

Actual behavior

The "Shortcut will open with Enhanced Tacking Protection disabled" text is under the mentioned options, even thow the ETP is still enabled.

Device information

• Focus version: Focus Beta 109.0b1
• NOT reproducible on RC 108.1.0
• Android device model: Lenovo tab M10 (Android 10), Sony Xperia Z5 Premium (Android 7.1.1)

Any additional information?

• Not reproducible on Fenix Beta 109.0b1

Comment 1

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1805836 - Hide warning when ETP is enabled. (#338)

Comment 2

[Mihai Adrian Carare [:mcarare]]

Submitted a patch, also nominated the fix for uplift.

Comment 3

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1805836 - Hide warning when ETP is enabled and show it when disabled (backport #338) (#342)

Comment 4

[miralobontiu]

Verified as fixed on the latest Focus Nightly 110.0a1 from 12/20 with Google Pixel 6 (Androi 13), and Oppo Reno 6 (Android 12).

Comment 5

[Ryan VanderMeulen [:RyanVM]]

The fix was merged for v109 and v110.
main: https://github.com/mozilla-mobile/firefox-android/commit/3177935c6ca5063cf61ea010311c7cc3738281eb
v109: https://github.com/mozilla-mobile/firefox-android/commit/801e79cfcbf144f6c953483a2ee34aef577c5914

Comment 6

[miralobontiu]

Verified as fixed also on Beta 109.0b2.

Comment 7

[Chris Peterson [:cpeterson]]

Fixed in 109

Comment 8

[miralobontiu]

Verified as fixed also on RC 109.1.0.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba5e73be92a1
Hide warning when ETP is enabled.
https://hg.mozilla.org/integration/autoland/rev/399a9032c887
Correctly check for ETP disabled on specific site.