1805885 - Useless line in NS_MaybeOpenChannelUsingOpen()

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

https://searchfox.org/mozilla-central/source/netwerk/base/nsNetUtil.cpp#2597 does nothing; it's left over from a refactor

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

also #2603

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1520868

Comment 3

[Tom S]

The whole function seems rather useless to me.

Comment 4

[Tyler]

I would love to get his technical debt closed out as my first patch. Can someone assign it to me?

Comment 5

[Tyler]

Attachment: Bug 1805885 - Removed unnecessary functions NS_MaybeOpenChannelUsingOpen() and NS_MaybeOpenChannelUsingAsyncOpen(). Also refactored callers of these functions to not use them. r?Valentin

Comment 6

[Tyler]

I uploaded a patch that should remove the references to these two functions. I also refactored calls to the functions to no longer rely on them.

Let me know if you have any questions or what else I can do to help get his resolved.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d0175c12656
Removed unnecessary functions NS_MaybeOpenChannelUsingOpen() and NS_MaybeOpenChannelUsingAsyncOpen(). Also refactored callers of these functions to not use them. r=valentin,necko-reviewers

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3d0175c12656

Comment 9

[Valentin Gosu [:valentin] (he/him)]

Thank you for fixing this, Tyler!