Closed Bug 1805885 Opened 2 years ago Closed 2 years ago

Useless line in NS_MaybeOpenChannelUsingOpen()

Categories

(Core :: Networking, defect, P3)

defect

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox-esr102 --- wontfix
firefox108 --- wontfix
firefox109 --- wontfix
firefox110 --- fixed

People

(Reporter: jesup, Assigned: woot903)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [good-first-bug][necko-triaged])

Attachments

(1 file)

also #2603

Regressed by: 1520868

Set release status flags based on info from the regressing bug 1520868

The whole function seems rather useless to me.

Severity: -- → S4
Priority: -- → P3
Whiteboard: [good-first-bug] → [good-first-bug][necko-triaged]

I would love to get his technical debt closed out as my first patch. Can someone assign it to me?

Flags: needinfo?(rjesup)
Assignee: nobody → woot903
Status: NEW → ASSIGNED

I uploaded a patch that should remove the references to these two functions. I also refactored calls to the functions to no longer rely on them.

Let me know if you have any questions or what else I can do to help get his resolved.

Flags: needinfo?(valentin.gosu)
Attachment #9310939 - Attachment description: Bug 1805885 - Removed unnecessary functions NS_MaybeOpenChannelUsingOpen() and NS_MaybeOpenChannelUsingAsyncOpen(). Also refactored callers of these functions to not use them. r?Valentin Gosu → Bug 1805885 - Removed unnecessary functions NS_MaybeOpenChannelUsingOpen() and NS_MaybeOpenChannelUsingAsyncOpen(). Also refactored callers of these functions to not use them. r?Valentin
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3d0175c12656
Removed unnecessary functions NS_MaybeOpenChannelUsingOpen() and NS_MaybeOpenChannelUsingAsyncOpen(). Also refactored callers of these functions to not use them. r=valentin,necko-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch

Thank you for fixing this, Tyler!

Flags: needinfo?(valentin.gosu)
Flags: needinfo?(rjesup)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: