Closed
Bug 1805885
Opened 1 year ago
Closed 1 year ago
Useless line in NS_MaybeOpenChannelUsingOpen()
Categories
(Core :: Networking, defect, P3)
Core
Networking
Tracking
()
RESOLVED
FIXED
110 Branch
People
(Reporter: jesup, Assigned: woot903)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [good-first-bug][necko-triaged])
Attachments
(1 file)
https://searchfox.org/mozilla-central/source/netwerk/base/nsNetUtil.cpp#2597 does nothing; it's left over from a refactor
|
Reporter | |
Comment 1•1 year ago
|
||
also #2603
|
||
Updated•1 year ago
|
Keywords: regression
|
|
||
Comment 2•1 year ago
|
||
Set release status flags based on info from the regressing bug 1520868
status-firefox108:
--- → affected
status-firefox109:
--- → affected
status-firefox110:
--- → affected
status-firefox-esr102:
--- → affected
|
||
Updated•1 year ago
|
|
||
Comment 3•1 year ago
|
||
The whole function seems rather useless to me.
|
||
Updated•1 year ago
|
Severity: -- → S4
Priority: -- → P3
Whiteboard: [good-first-bug] → [good-first-bug][necko-triaged]
I would love to get his technical debt closed out as my first patch. Can someone assign it to me?
Flags: needinfo?(rjesup)
|
||
Updated•1 year ago
|
Assignee: nobody → woot903
Status: NEW → ASSIGNED
I uploaded a patch that should remove the references to these two functions. I also refactored calls to the functions to no longer rely on them.
Let me know if you have any questions or what else I can do to help get his resolved.
Flags: needinfo?(valentin.gosu)
|
|
||
Updated•1 year ago
|
Attachment #9310939 -
Attachment description: Bug 1805885 - Removed unnecessary functions NS_MaybeOpenChannelUsingOpen() and NS_MaybeOpenChannelUsingAsyncOpen(). Also refactored callers of these functions to not use them. r?Valentin Gosu → Bug 1805885 - Removed unnecessary functions NS_MaybeOpenChannelUsingOpen() and NS_MaybeOpenChannelUsingAsyncOpen(). Also refactored callers of these functions to not use them. r?Valentin
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3d0175c12656 Removed unnecessary functions NS_MaybeOpenChannelUsingOpen() and NS_MaybeOpenChannelUsingAsyncOpen(). Also refactored callers of these functions to not use them. r=valentin,necko-reviewers
|
||
Comment 8•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
|
||
Comment 9•1 year ago
|
||
Thank you for fixing this, Tyler!
Flags: needinfo?(valentin.gosu)
Flags: needinfo?(rjesup)
You need to log in
before you can comment on or make changes to this bug.
Description
•