1806002 - ./mach addwidget should add an entry to the whitelist in "browser_all_files_referenced.js"

Status: NEW

(Toolkit :: UI Widgets, task)

Description

[Tim Giles [:tgiles]]

Since we've been landing reusable components without them replacing existing elements, the browser_all_files_referenced.js test will fail since these newly added components aren't being used in Firefox. This puts us in a bit of a bind, as we would want to land the components without needing to immediately use them in Firefox. We can get around this issue by adding an entry to the whitelist array within the test. Adding this entry should be something that is handled by ./mach addwidget so that developers don't need to remember that they need to add this entry (and then learning that they need to add it once a patch is backed out for failing the browser_all_files_referenced.js test).

Comment 1

[Mark Striemer [:mstriemer]]

This is still causing backouts on initial landings so it would be nice to avoid that happening. However we don't want to start muddying this ignore list in browser_all_files_referenced.js. It may be a good idea to add the opposite test to that file when we do this so that if a file is imported but is in the allow list then we fail the test