1806156 - `testing/webdriver` emits `rustc` error with Rust 1.66

Status: RESOLVED FIXED

(Testing :: geckodriver, defect)

Description

[Erich Gubler [:ErichDonGubler]]

On current autoland (revision 564efd83794f), when Rust 1.66 is used as the toolchain backing a ./mach build invocation, an error is raised for warp::generic::Tuple not being fulfilling by current trait bounds in server::create_warp_routes:

# With Rust 1.66 set as the current Rust toolchain, i.e., via `rustup default stable`:
$ ./mach build

0:42.89    Compiling webdriver v0.47.0 (C:\Users\Erich\workspace\mozilla-source\mozilla-unified\testing\webdriver)
 0:43.39 error: opaque type `impl warp::Filter + Clone + warp::filter::FilterBase<Extract = impl Reply, Error = Rejection>` does not satisfy its associated type bounds
 0:43.39    --> testing\webdriver\src\server.rs:257:18
 0:43.39     |
 0:43.39 257 | ) -> impl Filter<Extract = impl warp::Reply, Error = Rejection> + Clone {
 0:43.39     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:43.39     |
 0:43.39    ::: C:\Users\Erich\workspace\mozilla-source\mozilla-unified\third_party\rust\warp\src\filter\mod.rs:40:19
 0:43.39     |
 0:43.40 40  |     type Extract: Tuple; // + Send;
 0:43.40     |                   ----- this associated type bound is unsatisfied for `impl Reply`
 0:43.40     |
 0:43.40     = note: `-D opaque-hidden-inferred-bound` implied by `-D warnings`
 0:43.40 help: add this bound
 0:43.40     |
 0:43.40 257 | ) -> impl Filter<Extract = impl warp::Reply + warp::generic::Tuple, Error = Rejection> + Clone {
 0:43.41     |                                             ++++++++++++++++++++++
 0:43.46 error: could not compile `webdriver` due to previous error

This error matches a new issue already in warp upstream, which has been resolved after a user workaround was found (changing impl Reply to be (impl Reply,). This blocks an eventual upgrade to Rust 1.66. Because of this, it can disrupt any Rust users may already be using.

Comment 1

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1806156: Fix `webdriver::server::build_warp_routes` compile failures with Rust 1.66 r=#webdriver-reviewers

See also the following links from upstream:

• Issue: https://github.com/seanmonstar/warp/issues/1013
• Resolution:
  https://github.com/seanmonstar/warp/issues/1012#issuecomment-1353651684

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86a2b795327e
Fix `webdriver::server::build_warp_routes` compile failures with Rust 1.66 r=webdriver-reviewers,jgraham

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/86a2b795327e