1806169 - Switch more invocations of JS parser to use UTF-8 parser

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

Now that we have UTF-8 JS parsing support, the char16_t should be deprecated. Numerous loaders in gecko decode from streams and then parse to JS. This bug is about switching those cases to decode into UTF8 before parsing. These cases already required well-formed UTF16, so using UTF8 as the target instead is can be done without further information loss.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1806169 - Add ScriptLoader::ConvertToUTF8 overload

Similar to the ConvertToUTF16 overload for JS owned strings, add an overload for
the UTF8 case. This simplifies later work to switch parsing to UTF8.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1806169 - Use UTF8 JS parser for PrototypeDocumentContentSink

Depends on D164930

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1806169 - Use UTF8 JS parser for nsFrameMessageManager

Depends on D164931

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1806169 - Use UTF8 JS parser for ChromeScriptLoader

Depends on D164932

Comment 5

[Ted Campbell [:tcampbell]]

Attachment: Bug 1806169 - Use UTF8 parser for Worklet code

Depends on D164933

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/300945b39f81
Add ScriptLoader::ConvertToUTF8 overload r=jonco
https://hg.mozilla.org/integration/autoland/rev/0df4af33a26e
Use UTF8 JS parser for PrototypeDocumentContentSink r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/089548c43a16
Use UTF8 JS parser for nsFrameMessageManager r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/3bdaef5f3363
Use UTF8 JS parser for ChromeScriptLoader r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/0734671d309a
Use UTF8 parser for Worklet code r=hsivonen

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/300945b39f81
https://hg.mozilla.org/mozilla-central/rev/0df4af33a26e
https://hg.mozilla.org/mozilla-central/rev/089548c43a16
https://hg.mozilla.org/mozilla-central/rev/3bdaef5f3363
https://hg.mozilla.org/mozilla-central/rev/0734671d309a