1806218 - Overscrollable directions in APZHandledResult are sometimes incorrect

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Botond Ballo [:botond]]

In bug 1785754, I expanded the geckoview-junit test InputResultDetailTest#testTouchAction to test what values are returned in APZHandledResult in a more comprehensive combination of scenarios:

• target is root frame vs. subframe
• target is scrollable vs. non-scrollable
• target has an APZ-aware event handler vs. not
• target has various touch-action values

In this process I discovered that in a subset of cases, the mOverscrollDirections are incorrect (see the FIXME comment in D164586).

This issue tracks fixing the overscroll directions in the affected cases.

Comment 1

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1806218 - Fix faulty overscroll directions in evaluated touch actions. r?dlrobertson

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5fec4580148
Fix faulty overscroll directions in evaluated touch actions. r=dlrobertson,geckoview-reviewers,owlish

Comment 3

[Iulian Moraru]

Backed out for causing gtest failures.

• Push with failures

• Failure log

• Backout link

[task 2023-07-12T20:48:26.830Z] 20:48:26     INFO -  TEST-START | APZEventResultTesterMock.HandledByRootApzcFlag
[task 2023-07-12T20:48:26.830Z] 20:48:26  WARNING -  TEST-UNEXPECTED-FAIL | APZEventResultTesterMock.HandledByRootApzcFlag | Expected equality of these values:
[task 2023-07-12T20:48:26.830Z] 20:48:26     INFO -    delayedAnswer
[task 2023-07-12T20:48:26.830Z] 20:48:26     INFO -      Which is: handled: unhandled, scrollable: [], overscroll: either
[task 2023-07-12T20:48:26.830Z] 20:48:26     INFO -    (APZHandledResult{APZHandledPlace::Unhandled, SideBits::eNone, ScrollDirections()})
[task 2023-07-12T20:48:26.831Z] 20:48:26     INFO -      Which is: handled: unhandled, scrollable: [], overscroll: none
[task 2023-07-12T20:48:26.831Z] 20:48:26     INFO -   @ /builds/worker/checkouts/gecko/gfx/layers/apz/test/gtest/TestEventResult.cpp:465
[task 2023-07-12T20:48:26.831Z] 20:48:26  WARNING -  TEST-UNEXPECTED-FAIL | APZEventResultTesterMock.HandledByRootApzcFlag | test completed (time: 0ms)
[task 2023-07-12T20:48:26.831Z] 20:48:26     INFO -  TEST-START | APZCFlingAccelerationTester.TwoNormalFlingsShouldAccelerate

Comment 4

[Alex Jakobi [:ajakobi]]

@imoraru : I have submitted a fix which looks like it's passing:
https://treeherder.mozilla.org/jobs?repo=try&revision=d82718e972eff6d37bb6d6e9240fdb978d082369

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cfa5cdad7b0
Fix faulty overscroll directions in evaluated touch actions. r=dlrobertson,geckoview-reviewers,owlish

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0cfa5cdad7b0