1806355 - macOS menu bar doesn't reappear after exiting fullscreen YouTube

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Chris Peterson [:cpeterson]]

Attachment: screenshot.png

[Tracking Requested - why for this release]:

This bug is a regression to YouTube. I bisected this regression to the pushlog for bug 1631735:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b4d604939fe8faeb0c25fdd3dbc363aafb9ea54d&tochange=781c1031c032d34e99749bc4f0f2726593879afe

Steps to reproduce

1. Open any video page on https://www.youtube.com/.
2. Zoom (not fullscreen) the Firefox window by Option + clicking the window's green ⨁ button. The bug doesn't reproduce if the window is not the full height and full width of the screen (excluding the application menu bar).
3. Press "f" to enter fullscreen. You don't need to actually play the video to reproduce this bug.
4. Press Esc to exit fullscreen.

Expected behavior

The macOS menu bar should reappear.

Actual behavior

The macOS menu bar does not reappear. See the attached screenshot.

If I first set full-screen-api.macos-native-full-screen pref = true, then menu bar reappears as expected after exiting fullscreen YouTube.

Comment 1

[Stephen A Pohl [:spohl]]

We should fix this or revert the changes from bug 1631735 until we can reland without this regression.

Comment 2

[Markus Stange [:mstange]]

Let's revert the changes, Brad is on PTO. I'll ask for a backout.

Comment 3

[Daniel Veditz [:dveditz]]

I'm sure y'all know this since you backed out general bug 1631735, but for the record it wasn't just YouTube. When I noticed this I tried full-screen video on several other sites (multiple news sites, airmo) and all were the same. Had to manually exit App-Fullscreen using ⇧⌘F

This bug can be resolved fixed, right? Works for me now that I've updated past the back-out.

Comment 4

[Stephen A Pohl [:spohl]]

Yes, thank you. Fixed by backout of bug 1631735.

Comment 5

[Monica Chiorean]

I was able to reproduce this issue on Mac 10.13 using build 110.0a1(20221218093715).
Verified as fixed on Mac 10.13 using build 110.0b3(20230119185824) and 111.0a1(20230120093625).