Closed Bug 1806389 Opened 2 years ago Closed 2 years ago

Use Shape instead of JSClass to check for native/proxy objects in a few more places

Categories

(Core :: JavaScript Engine, task)

task

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(2 files)

No description provided.

obj->is<ProxyObject>() now checks the shape and avoids loading the JSClass.

We can then also remove the JSClass argument from GetBuiltinTagFast.

We have to load the JSClass anyway so it's not clear how much it helps, but
it also shouldn't be worse.

Depends on D165015

Attachment #9308908 - Attachment description: Bug 1806389 part 2 - Use shape to check for native objects in trace and finalize hooks. r?jonco! → Bug 1806389 part 2 - Use shape to check for native objects in object trace and finalize code. r?jonco!
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/406566859913 part 1 - Optimize proxy check in obj_toString. r=jonco https://hg.mozilla.org/integration/autoland/rev/0468f7d93556 part 2 - Use shape to check for native objects in object trace and finalize code. r=jonco
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: