1806398 - Crash in private mode after upgrade to 108 related to IDB encryption in PBM

Status: RESOLVED INVALID

(Core :: Storage: IndexedDB, defect, P3)

Description

[onlylogout]

Attachment: stacktrace.log

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Firefox/108.0

Steps to reproduce:

1. Ensure you have ublock origin installed and enabled (I suspect it should cache its files first)
2. Ensure history is not enabled and the browser runs in private mode
3. Upgrade the browser from 106 to 108 (fedora37 package firefox-108.0-2.fc37.x86_64)
4. Launch firefox
5. Observe the crash

Actual results:

So the browser crashes. The stack trace is attached in the stacktrace.log file. After a preliminary look, it seems that it's related to the newly introduced IDB encryption. Possibly the data was incorrectly migrated, since after deleting all PBM IDB data files for the ublock extension, firefox starts normally.

The crash happens here:

mozilla::dom::indexedDB::(anonymous namespace)::CreateFileBlobImpl (aId=9255, aNativeFile=<synthetic pointer>..., aDatabase=...) at /usr/src/debug/firefox-108.0-2.fc37.x86_64/dom/indexedDB/ActorsParent.cpp:5628

to me it seems to suggest that the cipher key is somehow not present for the file..
5628 MOZ_RELEASE_ASSERT(key.isSome());

I can provide the migrated IDB data, but I don't have the old unencrypted data files anymore.

Expected results:

Expected results are that the data for the extension should be properly migrated and the browser shouldn't crash :)

Comment 1

[onlylogout]

I didn't bold it, but I want to reiterate that after deleting the "moz-extension+++068f467a-f67b-483b-a9b8-18a82c53b2b2^privateBrowsingId=1" folder, firefox starts normally (and a new folder with the same name is created there).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Storage: IndexedDB' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Harveer Singh]

IDB encryption should be under configuration toggle. Could you please confirm if we have enabled the configuration 'dom.indexedDB.privateBrowsing.enabled' in this system ?

Comment 4

[onlylogout]

(In reply to Harveer Singh from comment #3)

IDB encryption should be under configuration toggle. Could you please confirm if we have enabled the configuration 'dom.indexedDB.privateBrowsing.enabled' in this system ?

I have this setting set to true (it displays as bold). However I don't remember toggling it "unprovoked", I may have toggled it (still not sure) because something didn't work in private mode.

Comment 5

[Harveer Singh]

So, this feature is still under development. So, I am going to put this bug in our backlog and will definitely ensure that this bug gets fixed before we officially release it.

Comment 6

[Harveer Singh]

We have completely redesigned the IDB storage under private browsing mode. Would that be possible for you to verify the bug by running this again?

Comment 7

[onlylogout]

I'm afraid I'd not be able to recheck the exact scenario, I'm on Fedora 38, that version of firefox is no longer available and I don't have any old pre-upgrade data. I can only say that I'm currently using this setting and I didn't observe any problems with that.

Comment 8

[Harveer Singh]

Okay, based on your feedback and our observations. I think it's safe to close this bug now as invalid as this is not relevant in our new design. If you see the occurrence in future, please feel free to open it again.