Closed Bug 1806472 Opened 1 year ago Closed 1 year ago

Avoid redundant calls to fromNow

Categories

(Taskcluster :: General, task)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sergesanspaille, Assigned: sergesanspaille)

Details

Attachments

(1 file)

When computing fromNow in transforms/task.py, some calls could be moved outside a loop to avoid redundant computation.

Basic loop invariant code motion. The impact on execution time is not
totally negligible due to the number of tests involved.

Depends on D164789

Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cab601f1b07d
Move redundant call to fromNow r=taskgraph-reviewers,ahal,jlorenzo

Backed out 4 changesets (Bug 1805842, Bug 1806472, Bug 1806473, Bug 1803537) for causing build bustage on Gecko Decition Task.
Backout link
Push with failures <--> D
Failure Log

Flags: needinfo?(sguelton)
Type: enhancement → task
Attachment #9308995 - Attachment description: Bug 1806472 - Move redundant call to fromNow → Bug 1806472 - Move redundant call to fromNow r=ahal
Attachment #9308995 - Attachment description: Bug 1806472 - Move redundant call to fromNow r=ahal → Bug 1806472 - Move redundant call to fromNow r=ahal!
Pushed by sguelton@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bdda8bf95643
Move redundant call to fromNow r=ahal,jlorenzo
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Flags: needinfo?(sguelton)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: