Open Bug 1806583 Opened 2 years ago Updated 2 years ago

Flip prefer-const ESLint rule in newtab/

Categories

(Firefox :: Messaging System, enhancement, P3)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

People

(Reporter: aminomancer, Assigned: emcminn)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(2 obsolete files)

There's a TODO comment in our ESLint rules to flip prefer-const to on (it's currently off). Most of the violators should be auto-fixable so this may not be too hard to switch on.

Here's the rule for reference

Assignee: nobody → emcminn
Attachment #9309394 - Attachment description: WIP: Bug 1806583 - Turn on prefer-const for newtab eslint → Bug 1806583 - Turn on prefer-const for newtab eslint
See Also: → 1807181
Iteration: --- → 110.2 - Dec 26 - Jan 6
Priority: -- → P1
Attachment #9310562 - Attachment is obsolete: true
Attachment #9309394 - Attachment is obsolete: true

We've had some discussion and it turns out there's not actually consensus on whether or not prefers-const is desirable, and we'd like to avoid turning things on at the warning level.
We're going to put this on hold pending some decision on https://bugzilla.mozilla.org/show_bug.cgi?id=1803560 (a lot of the discussion can be viewed there) and then we can resolve this bug based on whichever rules are decided on to apply codebase-wide.

Iteration: 110.2 - Dec 26 - Jan 6 → ---
Depends on: 1803560
Priority: P1 → P3
Blocks: fxms-build
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: