1806590 - Downloads panel doesn't pop up from private window if screenshots.browser.component.enabled = true

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect)

Description

[6k64x4ma]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0

Steps to reproduce:

1. Set screenshots.browser.component.enabled to true.
2. Open a private window and a non-private window.
3. Take screenshot on the private window -> click "Download".

Actual results:

The downloads panel pops up from the non-private window.

Expected results:

The downloads panel should pop up from the private window.

Comment 1

[Peter Magyari]

Hi,

I was able to reproduce the issue with screenshots.browser.component.enabled set to true but you don't need to change this pref in order to make the screenshot feature to work. If you leave it in the default false state it does not occur.

Could you please also confirm this?

Thanks!

Comment 2

[6k64x4ma]

Yes, the download button appears on the private window if screenshots.browser.component.enabled is false.
(The pref will be flipped eventually (Bug 1789727), so I was trying it out of curiosity.)

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1806590 - Downloading screenshot now shows panel in private windows. r=sfoster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d4a091f379e
Downloading screenshot now shows panel in private windows. r=sfoster

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3d4a091f379e

Comment 6

[Peter Magyari]

I have verified the fix on MacOS 11 and Windows 10 using Nightly 110.0a1 (20230111043919)