1806645 - PgUp/PgDn not working properly in the datepicker for date and datetime-local inputs

Status: VERIFIED FIXED

(Firefox :: Disability Access, defect)

Description

[Ina Popescu, Desktop QA]

Found in

• Firefox 109.0b4

Affected versions

• Firefox 109.0b4

Tested platforms

• Affected platforms: Windows 10, Ubuntu 22.04, macOS 11
• Unaffected platforms: none

Preconditions

• Firefox build installed

Steps to reproduce

1. Copy and paste in the URL bar following code: data:text/html, <input type='date'>
2. Hit TAB key to reach the Calendar button
3. Hit Enter or Space key to open the datepicker
4. Hit TAB key again to reach the Calendar panel
5. Hit PgUp/PgDn keys repeatedly

Expected result

• According to specification "Page up/Page Down changes the view to the previous month and sets focus on the same day. If that day does not exist, then it moves focus to the same day of the same week."

Actual result

• Hitting PgUp key repeatedly will eventually stop from moving the focus to the same day from the previous month
  Hitting PgUp/PgDn keys repeatedly will eventually skip a day(e.g. 01.01.2023,02.01.2023, 03.03.2023)

Regression range

• Not a regression because these improvements were recently implemented through Bug 1676068.

Additional notes

• Issue encountered in the default datepicker data:text/html,<input type='datetime-local'> too.
• The issue can not be reproduced on Google Chrome or W3C example https://www.w3.org/WAI/ARIA/apg/example-index/dialog-modal/datepicker-dialog.html.
• Using PgUp key in Nightly, it loses focus on a certain previous month.

Comment 1

[Ina Popescu, Desktop QA]

Attachment: PgDn and PgUp in Beta.mp4

Comment 2

[Ina Popescu, Desktop QA]

Attachment: PgDn and PgUp in Nightly.mp4

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:asa, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1806645 - Ensure PgUp/PgDown update datepicker calendar as expected. r?mconley,kcochrane,Jamie

Updating automatic tests to ensure the Page Up and Page Down keypresses do not miss a day after 11 changes and add minor corrections to the test case descriptions.

Depends on D167099

Depends on D167099

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c521627f263f
Ensure PgUp/PgDown update datepicker calendar as expected. r=kcochrane

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c521627f263f

Comment 7

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 111.0a1 (2023-01-22).

Comment 8

[Anna Yeddi [:ayeddi]]

Comment on attachment 9313135 [details]
Bug 1806645 - Ensure PgUp/PgDown update datepicker calendar as expected. r?mconley,kcochrane,Jamie

Beta/Release Uplift Approval Request

• User impact if declined: The keyboard accessibility allows users with screen readers and users with limited mobility access the functionality of this component - a date picker calendar for date and datetime-local inputs only. The patch ensures that the calendar grid itself still consistently provides a focusable day for a keyboard user to get to the calendar grid and be able to navigate between days to make a selection, avoiding the focused element to be shifted one day after 12 key presses, because of UTC vs localized date calculations that used to be handled by a custom function, but now the logic is handled by the dateKeeper component (per bug 1803608)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: (included in the bug description)
• List of other uplifts needed: Bug 1803608, Bug 1806823
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes only impact keyboard accessibility for one component only (a date picker calendar for date and datetime-local inputs only), it does not change any looks and no other aspects of the feel of these components

• Low risk improvements early in the cycle (the keyboard accessibility was only added in 109)
• Enabling features that have been validated/tested by QA (the fix for this bug and for its parent in the stack, the bug 1806645, have been tested and confirmed by the QA team)

• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9313135 [details]
Bug 1806645 - Ensure PgUp/PgDown update datepicker calendar as expected. r?mconley,kcochrane,Jamie

Approved for 110 beta 5, thanks.

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/b1b57ba27103

Comment 11

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Beta build 110.0b5.