Closed Bug 1806721 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 37611 - Revert "[Reland] Use direct compositing for canvases rendered on the CPU"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37611 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37611
Details from upstream follow.

Juanmi Huertas <juanmihd@chromium.org> wrote:

Revert "[Reland] Use direct compositing for canvases rendered on the CPU"

This reverts commit c8d899de337311d5ff778bdcb43499ab9e272ad4.

Reason for revert: Inspect overlay not working on mac

Original change's description:

[Reland] Use direct compositing for canvases rendered on the CPU

Before this CL, we already had the plumbing for presenting CPU-rendered
canvases via GpuMemoryBuffer for direct compositing. That code path was
originally implemented to support LowLatency mode. With this change, we
exercise the GpuMemoryBuffer code path for "regular" latency canvases.
This accelerates compositing, especially for pages that have many
canvases.

With this change, MotionMark Images test runs significantly faster on
MacOS with angle/metal enabled.

Reland of original CL: https://chromium-review.googlesource.com/c/chromium/src/+/4081383

Bug: 1363627
Change-Id: I9380c7f722954af934a657a71c36c37122731f45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4091749
Reviewed-by: Juanmi Huertas \<juanmihd@chromium.org>
Commit-Queue: Justin Novosad \<junov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1083400}

Bug: 1363627
Change-Id: I77199abb7e92f9a2e4d2f146e26d9d043e69ea84

Reviewed-on: https://chromium-review.googlesource.com/4116826
WPT-Export-Revision: dc735285767a43e024e158c44fcb6cd8457aac06

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 4

Chrome

PASS: 4

Safari

PASS: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc67f884d232 [wpt PR 37611] - Revert "[Reland] Use direct compositing for canvases rendered on the CPU", a=testonly
You need to log in before you can comment on or make changes to this bug.