1806844 - 12.75 - 2.01% cpstartup content-process-startup / ts_paint (OSX) regression on Sat December 17 2022

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect, P3)

Description

[Alex Finder]

Perfherder has detected a talos performance regression from push e7bad90843c66aaf5d246b8dba73e46beeba3663. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
13%	cpstartup content-process-startup	macosx1015-64-shippable-qr	e10s fission stylo webrender	102.58 -> 115.67
2%	ts_paint	macosx1015-64-shippable-qr	e10s fission stylo webrender	1,040.96 -> 1,061.83

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1806140

Comment 2

[Jonathan Kew [:jfkthame]]

I think this (and the related bug 1806851) is an expected result of the fact that we're now (correctly) loading both the Regular and Italic faces of the system font, instead of only the Regular one.

We could perhaps try initializing the system font family more lazily. I'll push a try job and see how it looks. Leaving ni? in place for now...

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1806844 - Use lazier initialization for the macOS system font family. r=#gfx-reviewers

This should marginally improve content-process startup for processes that don't immediately
need to use the system font. No actual change in behavior, just taking the initialization
of the system-font faces out of the startup path.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c0ca53e277a
Use lazier initialization for the macOS system font family. r=gfx-reviewers,lsalzman

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2c0ca53e277a

Comment 7

[Acasandrei Beatrice (needinfo me)]

== Change summary for alert #36607 (as of Tue, 27 Dec 2022 10:18:13 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
7%	Base Content Heap Unclassified	macosx1015-64-shippable-qr	fission	2,724,171.08 -> 2,522,382.00
7%	Base Content Heap Unclassified	macosx1015-64-shippable-qr	fission	2,713,116.67 -> 2,524,237.33

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36607

Comment 8

[Andrej (:aglavic)]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c0ca53e277a
Use lazier initialization for the macOS system font family.
r=gfx-reviewers,lsalzman

== Change summary for alert #36643 (as of Thu, 29 Dec 2022 19:20:37 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
11%	cpstartup content-process-startup	macosx1015-64-shippable-qr	e10s fission stylo webrender	114.21 -> 101.83
9%	cpstartup content-process-startup	macosx1015-64-shippable-qr	e10s fission stylo webrender	112.71 -> 102.33
9%	cpstartup content-process-startup	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	113.33 -> 102.92

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36643