1806859 - cleanup fallback flag logic

Status: RESOLVED FIXED

(Conduit :: moz-phab, task)

Description

[Connor Sheehan [:sheehan]]

And add tests for the fallback behaviour.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: args: move fallback checking into a separate function (Bug 1806859) r?grammar

Right now we set a fallback flag to False, check
a set of conditions for fallback, and if they are
met we set the flag to True and then take some
further action down the line.

Instead, move the fallback checking into a function
and store the result of that function as fallback.
Then check the value of fallback where needed,
avoiding the need to set the flag to False in
the first place.

With the fallback behaviour in a separate function we can
also expand the conditions to make the behaviour more
readable, and add a test.