1806904 - [wdspec] Add dedicated "switch_to_parent_frame" method to WebDriver Python client

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right now the switch_frame method of the WebDriver Python client has to be called with the frame argument set to parent. This is confusing if a page contains an element with the id parent.

def switch_frame(self, frame):
    if frame == "parent":
        url = "frame/parent"
        body = None
    else:
        url = "frame"
        body = {"id": frame}

    return self.send_session_command("POST", url, body)

As such it would be good to have a dedicated switch_parent_frame method available. The addition would require checks for all the tests under the following folders to make use that they make use of the new API:

https://searchfox.org/mozilla-central/source/testing/web-platform/mozilla/tests/webdriver/
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/

Comment 1

[Khalid AlHaddad]

Attachment: Bug 1806904 - Add dedicated "switch_to_parent_frame" method to the WebDriver Python client, r?#webdriver-reviewers

Comment 2

[Khalid AlHaddad]

Attachment: Bug 1806904 - Add dedicated "switch_to_parent_frame" method to WebDriver Python client. Rename method to "switch_to_frame", r?#webdriver-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3a5c9591a5d4
https://hg.mozilla.org/integration/autoland/rev/2ddededa11e6
Add dedicated "switch_to_parent_frame" method to the WebDriver Python client, r=webdriver-reviewers,whimboo

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/55594 for changes under testing/web-platform/tests

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2ddededa11e6

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org) from comment #4)

Created web-platform-tests PR
https://github.com/web-platform-tests/wpt/pull/55594 for changes under
testing/web-platform/tests

The upstream PR was manually merged.