1806970 - The navigational top picks are not triggered if the keyword contains an upper case

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: navigational top picks with uppercase.mp4

[Affected versions]:

• Nightly 110.01a

[Affected Platforms]:

• Mac 12.4
• Windows 10 x64
• Linux Mint 20

[Prerequisites]:

• Have a new profile with the following prefs set:
• browser.search.region to US
• browser.urlbar.quicksuggest.dataCollection.enabled to true
• browser.urlbar.merino.providers to adm,top_picks

[Steps to reproduce]:

1. Open the Nightly browser with the profile from the prerequisites.
2. Type IMDb in the awesomebar with uppercase.
3. Observe the behavior.

[Expected result]:

• The imdb navigational top pick is correctly displayed in the first position.

[Actual result]:

• The imdb navigational top pick is NOT triggered.

[Notes]:

• The navigational top picks are only triggered if the keyword it's written in all lowercase.
• Attached is a screen recording of the issue.

Comment 1

[Taddes Korris [:taddes]]

Thank you for finding this [:cmuntean], should be a very simple fix. I'll take care of it and meanwhile will capture this reference in a Jira ticket so we have it in our workflow as well. If you catch anything else broadly for this provider or other Merino issues, feel free to tag myself [:taddes] or [:nanj] and we can be sure to have eyes on it with the right people assigned to handle the bugs.

Comment 2

[Taddes Korris [:taddes]]

Hi [:cmuntean]! The issue is now resolved and was merged in as part of the following pull request: https://github.com/mozilla-services/merino-py/pull/239. You can verify the correct result now, and this change was extended to support AdM and Top Picks, with possibility to support all future providers with query normalization. Feel free to review and let us know if you need anything else. Thanks for bringing this to our attention.

Comment 3

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Hi Taddes Korris! Thanks for fixing this issue! We will ping you and Nan in the feature if we find other Merino issues.

I have verified this issue on the latest Firefox Release 110.0.1 (Build ID: 20230321111920), Firefox Beta 112.0b7 (Build ID:20230326180212), and the latest Nightly 113.0a1 build (Build ID: 20230326214700) on Windows 10 x64, macOS 12.4 and Linux Mint 20.

• The navigational top picks are correctly triggered if the keyword contains upper cases.