1807255 - Unit conversion glean telemetry type cannot be recorded

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[Adrian Florinescu [:aflorinescu]]

Notes:

• Please note that the actual result is actually recording what it's shown in the address bar, so in that sense what telemetry records is correct given that the unit conversion is presented as a search suggestion, not an as unit conversion, but showing unit conversion as suggestion rather than as an unit conversion will never generate the expected glean unit conversion type.
• The STR below are reproducing the glean impression engagement type, but the issue applies for the engagement and abbandonment types as well.

Found in

• 110.0a1

Affected versions

• 110.0a1 (2022-12-22)

Tested platforms

• Windows 10

Preconditions

• browser.urlbar.searchEngagementTelemetry.enabled set true
• devtools.chrome.enabled set true
• browser.urlbar.unitConversion.enabled set true (default value)

Steps to reproduce

1. Open browser console and execute: Services.fog.testResetFOG();
2. Open a new tab and type 100 celsius.
3. Wait 2 seconds and execute in browser console Glean.urlbar.impression.testGetValue()

Expected result

The address bar suggestions shows on 2nd line a degree transformation to Farenheit as a copy paste - similar to what calculator does (maybe ?!?).
The telemetry ping records an unit conversion for the 2nd position in address bar.

Actual result

The address bar suggestions shows on 2nd line a degree transformation to Farenheit as a search suggestion.

The telemetry ping records:

• results: "search_engine,search_suggest,.."
• groups: "heuristic,search_suggest,...

Regression range

• New feature, N/A

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Screen Shot 2022-12-26 at 16.11.11.png

Thank you very much, Adrian.

I checked it, the STR should not show the unit conversion result since the syntax is invalid for the unit conversion. What we see like the unit conversion results are provided by Google Search Engine (it is my default search engine on Nightly), I think. Please see the attachment. This is what I saw. If so, it is the expected result.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Screen Shot 2022-12-26 at 16.13.52.png

To show the unit conversion result in Firefox, please type 100 celsius to fahrenheit instead of step 2.
Then, the second row (212℉) is the result of the unit conversion. Please see the attachment.
And, please see this test to know the available syntax and units. https://searchfox.org/mozilla-central/source/browser/components/urlbar/tests/unit/test_unitConversion.js

Could you check it?

Comment 3

[Cristian Baica [:cbaica], Release Desktop QA]

Hello Daisuke,
Adrian is currently on PTO so I'll take up his NI. I've tried with the steps you mentioned and I could get the ping.
Marking this as invalid.